-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create delegation with ids uses all validations #143
Create delegation with ids uses all validations #143
Conversation
…ame organization_id in tests
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added some inline explanatory comments.
test/liquid_voting_web/absinthe/mutations/create_delegation/existing_delegations_test.exs
Show resolved
Hide resolved
test/liquid_voting_web/absinthe/mutations/create_delegation/existing_delegations_test.exs
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice PR, thanks for the inline PR comments explaining some of the changes.
What do you think of updating the pre-existing absinthe test to have a CreateDelegation.WithEmails
namespace to the , to be consistent with CreateDelegation.WithIds
?
Only change suggestion I have. Otherwise, it's good to merge 💯
The delegation can be created by ID or by email. | ||
The delegation can be created using participant IDs or emails. | ||
|
||
If created using participant emails, new participant(s) will be created if |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
test/liquid_voting_web/absinthe/mutations/create_delegation/existing_delegations_test.exs
Show resolved
Hide resolved
test/liquid_voting_web/absinthe/mutations/create_delegation/existing_delegations_test.exs
Show resolved
Hide resolved
I agree, and done 👍 |
Edited the commit to mention the upsert and conflict resolution. |
…it (#143) Co-authored-by: Oliver Azevedo Barnes <oliverbarnes@hey.com>
closes #137