Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add deleteDelegation Absinthe functionality using participant IDs #153

Open
jinjagit opened this issue Oct 20, 2020 · 2 comments
Open

Add deleteDelegation Absinthe functionality using participant IDs #153

jinjagit opened this issue Oct 20, 2020 · 2 comments
Assignees

Comments

@jinjagit
Copy link
Member

jinjagit commented Oct 20, 2020

Following #143, we can create delegations using participant IDs (for pre-existing participants) in much the same way as with participant emails. Despite permitting participant IDs in the absinthe deleteDelegation mutation, however, we have no matching action(s).

This development should also include the voting results updates (on delegation deletions) that are covered in #44.

@oliverbarnes
Copy link
Member

Makes sense. I'd like to discuss having separate clauses for each scenario, though. And for the each of the error handling scenarios.

I had another look at the delegation creation resolver, and now it feels like it's doing a lot there. Same for the args validator - feels like it could be broken into different clauses as well? Maybe we can pair on this

@jinjagit
Copy link
Member Author

Maybe we can pair on this

Sounds like a good plan. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants