Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

:IcedSourcePopupShow and :IcedSourceShow throw errors in some cases #191

Closed
Cnly opened this issue Mar 12, 2020 · 5 comments
Closed

:IcedSourcePopupShow and :IcedSourceShow throw errors in some cases #191

Cnly opened this issue Mar 12, 2020 · 5 comments
Labels
bug Something isn't working

Comments

@Cnly
Copy link
Contributor

Cnly commented Mar 12, 2020

In some cases, instead of showing the source, :IcedSourcePopupShow throws the following error:

Failed to open popup: 'Vim(return):E731: using Dictionary as a String'.

and :IcedSourceShow throws:

Vim(call):E119: Not enough arguments for function: <SNR>67_noop
function <SNR>68__worker[12]..<SNR>67__publish, line 8

Steps to reproduce:

  1. Set up the minimal configuration as described at https://liquidz.github.io/vim-iced/#minimal_configuration
  2. lein new app test
  3. Open src/test/core.clj and run :IcedJackIn
  4. Move the cursor to defn and run :IcedSourcePopupShow and :IcedSourceShow. The commands should both error.
  5. Move the cursor to -main and run them again. The source should be shown properly.

Environment: Debian, NVIM v0.5.0-404-g49cd750d6, vim-iced revision 5764f80 (pulled just now)

@liquidz
Copy link
Owner

liquidz commented Mar 12, 2020

@Cnly Thanks for your reporting!
I can't take time today, so I'll have a look tomorrow.

@liquidz liquidz added the bug Something isn't working label Mar 12, 2020
@liquidz
Copy link
Owner

liquidz commented Mar 12, 2020

@Cnly I could reproduce the problem and fixed on dev branch.
Could you try dev branch?

I verified with NVIM v0.5.0-416-g2b00d1d09.

@Cnly
Copy link
Contributor Author

Cnly commented Mar 13, 2020

Can confirm this is fixed on dev now. Thanks!

@liquidz
Copy link
Owner

liquidz commented Mar 13, 2020

Thanks! I'll cut a new release this weekend.

@liquidz
Copy link
Owner

liquidz commented Mar 14, 2020

Closed by #192

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants