Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't depend on Qt private APIs #11

Open
6 of 7 tasks
plfiorini opened this issue May 15, 2022 · 0 comments
Open
6 of 7 tasks

Don't depend on Qt private APIs #11

plfiorini opened this issue May 15, 2022 · 0 comments
Assignees
@plfiorini
Labels
enhancement New feature or request
Milestone
1.0.0

Comments

@plfiorini
Copy link
Member

plfiorini commented May 15, 2022 •
edited
Loading

Right now the code heavily depends on Qt private APIs, both in the compositor and QPA code.
Here's what we need to do to remove this dependency:

  • Remove QObjectPrivate and replace the d pointer with a QScopedPointer
  • WaylandMouseTrackerPrivate no longer inherits from QQuickItemPrivate
  • WaylandQuickItemPrivate no longer inherits from QQuickItemPrivate
  • Copy code from QQuickItemPrivate::paintOrderChildItems() to be used by WaylandQuickOutput
  • Replace QFactoryLoader with a custom implementation to load our plugins
  • Remove QtCore private API usage from AuroraEdidSupport
  • Move Aurora::Compositor::Internal::WindowSystemEventHandler to the QPA plugin
@plfiorini plfiorini added the enhancement New feature or request label May 15, 2022
@plfiorini plfiorini added this to the 1.0.0 milestone May 15, 2022
@plfiorini plfiorini self-assigned this May 15, 2022
plfiorini added a commit that referenced this issue May 15, 2022
@plfiorini
Do not use QObjectPrivate
783657b 
In order to remove the dependency on Qt private APIs, we first need to
stop using QObjectPrivate.

Issue: #11
plfiorini added a commit that referenced this issue May 15, 2022
@plfiorini
Do not use QQuickItemPrivate
82db3d5 
We don't want to depend on Qt private APIs.

Issue: #11
plfiorini added a commit that referenced this issue May 15, 2022
@plfiorini
Replace QFactoryLoader with a custom implementation
3afca22 
Remove yet another dependency on Qt private APIs.

Issue: #11
plfiorini added a commit that referenced this issue Jun 12, 2022
@plfiorini
Remove most Qt private API usage
169a237 
Issue: #11
plfiorini added a commit that referenced this issue Jun 12, 2022
@plfiorini
edid: Remove QtCore private API usage from AuroraEdidSupport
c1b5a49 
Issue: #11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@plfiorini plfiorini

Labels
enhancement New feature or request
Projects
None yet
Milestone
1.0.0
Development

No branches or pull requests
1 participant
@plfiorini