feat: add iam roles filtering #5
Conversation
WalkthroughThe recent updates focus on enhancing IAM role filtering capabilities. A new admin page for rule management has been created, alongside API client methods, request handlers, and response logic. The database schema now includes IAM role filtering rules, with corresponding repository and model layers handling rule operations. Integration and unit tests ensure the functionality's robustness, while the web template reflects these additions, offering an improved user interface. Changes
Assessment against linked issues
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChat with CodeRabbit Bot (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Review Status
Actionable comments generated: 1
Configuration used: CodeRabbit UI
Files ignored due to filter (1)
- api/api.yaml
Files selected for processing (37)
- admin-page.html (1 hunks)
- api/prel_api/oas_client_gen.go (4 hunks)
- api/prel_api/oas_handlers_gen.go (2 hunks)
- api/prel_api/oas_interfaces_gen.go (2 hunks)
- api/prel_api/oas_json_gen.go (2 hunks)
- api/prel_api/oas_parameters_gen.go (1 hunks)
- api/prel_api/oas_request_decoders_gen.go (1 hunks)
- api/prel_api/oas_request_encoders_gen.go (1 hunks)
- api/prel_api/oas_response_decoders_gen.go (2 hunks)
- api/prel_api/oas_response_encoders_gen.go (2 hunks)
- api/prel_api/oas_router_gen.go (4 hunks)
- api/prel_api/oas_schemas_gen.go (7 hunks)
- api/prel_api/oas_server_gen.go (2 hunks)
- api/prel_api/oas_unimplemented_gen.go (2 hunks)
- api/prel_api/oas_validators_gen.go (1 hunks)
- db/query.sql (1 hunks)
- db/schema.sql (1 hunks)
- internal/gateway/postgresql/models.gen.go (1 hunks)
- internal/gateway/postgresql/query.sql.gen.go (3 hunks)
- internal/gateway/repository/iam_role_filtering.go (1 hunks)
- internal/handler/api_handler.go (2 hunks)
- internal/handler/converter.go (1 hunks)
- internal/handler/page_handler.go (1 hunks)
- internal/model/iam_role_filtering.go (1 hunks)
- internal/model/repository.go (1 hunks)
- internal/usecase/iam_role.go (1 hunks)
- internal/usecase/iam_role_test.go (1 hunks)
- internal/usecase/usecase.go (2 hunks)
- internal/usecase/usecase_suite_test.go (1 hunks)
- scripts/insert-debug-query.sh (4 hunks)
- test/integration/iam_role_filtering_test.go (1 hunks)
- test/integration/iam_role_test.go (1 hunks)
- test/testutil/clock.go (1 hunks)
- test/testutil/server.go (2 hunks)
- web/template/template.go (1 hunks)
- web/template/templates/_header.tpl (1 hunks)
- web/template/templates/admin_iam_role_filtering.tpl (1 hunks)
Files skipped from review due to trivial changes (2)
- scripts/insert-debug-query.sh
- test/testutil/clock.go
Files skipped from review as they are similar to previous changes (31)
- admin-page.html
- api/prel_api/oas_client_gen.go
- api/prel_api/oas_interfaces_gen.go
- api/prel_api/oas_request_decoders_gen.go
- api/prel_api/oas_request_encoders_gen.go
- api/prel_api/oas_response_decoders_gen.go
- api/prel_api/oas_router_gen.go
- api/prel_api/oas_schemas_gen.go
- api/prel_api/oas_server_gen.go
- api/prel_api/oas_unimplemented_gen.go
- api/prel_api/oas_validators_gen.go
- db/query.sql
- db/schema.sql
- internal/gateway/postgresql/models.gen.go
- internal/gateway/postgresql/query.sql.gen.go
- internal/gateway/repository/iam_role_filtering.go
- internal/handler/api_handler.go
- internal/handler/converter.go
- internal/handler/page_handler.go
- internal/model/iam_role_filtering.go
- internal/model/repository.go
- internal/usecase/iam_role.go
- internal/usecase/iam_role_test.go
- internal/usecase/usecase.go
- internal/usecase/usecase_suite_test.go
- test/integration/iam_role_filtering_test.go
- test/integration/iam_role_test.go
- test/testutil/server.go
- web/template/template.go
- web/template/templates/_header.tpl
- web/template/templates/admin_iam_role_filtering.tpl
Additional comments: 21
api/prel_api/oas_parameters_gen.go (3)
18-22: The addition of the
APIIamRoleFilteringRulesRuleIDDeleteParamsstruct is consistent with the pattern used for other API operations in the file. It defines a single fieldRuleIDfor the path parameter.24-33: The
unpackAPIIamRoleFilteringRulesRuleIDDeleteParamsfunction correctly extracts theRuleIDfrom the packed parameters. It follows the established pattern in the file.35-81: The
decodeAPIIamRoleFilteringRulesRuleIDDeleteParamsfunction properly decodes theRuleIDfrom the path, handles URL escaping, and validates that the parameter is not empty. It uses theuriandconvpackages for decoding and conversion, and returns a custom error type for decoding errors.api/prel_api/oas_response_encoders_gen.go (4)
- 87-153: The function
encodeAPIIamRoleFilteringRulesPostResponseis consistent with the previous function in terms of structure and error handling. The same refinement suggested for error handling inencodeAPIIamRoleFilteringRulesGetResponseshould be applied here for consistency and to handle client disconnections gracefully.
- 155-226: The function
encodeAPIIamRoleFilteringRulesRuleIDDeleteResponsefollows the same pattern as the previous functions. It would benefit from the same refinement for error handling to manage client disconnections effectively.
- 780-845: The function
encodeAdminIamRoleFilteringGetResponseencodes the admin page response for IAM role filtering. It is consistent with the other functions in terms of structure and error handling. The same refinement for error handling should be applied here as well.
- 777-849: > Note: This review was outside the patches, so it was mapped to the patch with the greatest overlap. Original lines [228-846]
All functions for encoding API responses follow a consistent pattern and would benefit from refined error handling to address client disconnections. This change should be applied throughout the file to maintain consistency and improve robustness.
api/prel_api/oas_json_gen.go (9)
17-21: The implementation of the
Encodemethod forAPIIamRoleFilteringRulesGetOKis standard and follows the expected pattern for JSON marshaling with thejxlibrary.40-107: The
Decodemethod forAPIIamRoleFilteringRulesGetOKincludes proper error handling and validation of required fields. However, ensure that theDecodemethod is called with a non-nil receiver to avoid potential nil pointer dereferences.123-127: The
Encodemethod forAPIIamRoleFilteringRulesPostOKis implemented correctly, mirroring the structure of theAPIIamRoleFilteringRulesGetOKEncodemethod.142-201: The
Decodemethod forAPIIamRoleFilteringRulesPostOKis correct, with appropriate error wrapping and required field validation. The pattern of checking for a nil receiver is consistent across the methods.217-221: The
Encodemethod forAPIIamRoleFilteringRulesPostReqfollows the established pattern for encoding JSON objects and is correctly implemented.236-297: The
Decodemethod forAPIIamRoleFilteringRulesPostReqcorrectly decodes the JSON object, including the required field validation logic.1302-1306: The
Encodemethod forIamRoleFilteringRuleis implemented correctly, with theencodeFieldshelper method modularizing the encoding process.1326-1399: The
Decodemethod forIamRoleFilteringRuleincludes proper error handling and validation of required fields. The pattern of using a non-nil receiver is consistent and should be ensured when calling this method.14-315: > Note: This review was outside the patches, so it was mapped to the patch with the greatest overlap. Original lines [17-1413]
The JSON marshaling and unmarshaling methods for the various structs in this file are implemented consistently and correctly. The use of the
jxlibrary is appropriate, and the error handling and validation logic are in line with best practices.api/prel_api/oas_handlers_gen.go (5)
22-154: The implementation of
handleAPIIamRoleFilteringRulesGetRequestseems to follow the correct logic for handling a GET request. However, ensure that the security middleware (securityCookieAuth) is thoroughly tested to prevent unauthorized access.156-303: The
handleAPIIamRoleFilteringRulesPostRequestfunction adds support for POST requests. It's important to verify that the input validation for the POST data is robust to prevent injection attacks or processing of invalid data.305-452: In
handleAPIIamRoleFilteringRulesRuleIDDeleteRequest, ensure that theruleIDparameter is properly validated and sanitized before use to prevent path traversal or injection attacks.1684-1816: The
handleAdminIamRoleFilteringGetRequestfunction is responsible for serving the IAM role filtering admin page. It is crucial to confirm that only authorized administrative users can access this endpoint.1681-1820: > Note: This review was outside the patches, so it was mapped to the patch with the greatest overlap. Original lines [454-1817]
The general pattern for handling requests, including starting spans, recording metrics, and invoking middleware, is consistent across all functions. Ensure that the middleware and authentication checks are correctly implemented and tested to prevent security issues.
There was a problem hiding this comment.
Review Status
Actionable comments generated: 2
Configuration used: CodeRabbit UI
Files ignored due to filter (1)
- api/api.yaml
Files selected for processing (39)
- admin-page.html (1 hunks)
- api/prel_api/oas_client_gen.go (4 hunks)
- api/prel_api/oas_handlers_gen.go (2 hunks)
- api/prel_api/oas_interfaces_gen.go (2 hunks)
- api/prel_api/oas_json_gen.go (2 hunks)
- api/prel_api/oas_parameters_gen.go (1 hunks)
- api/prel_api/oas_request_decoders_gen.go (1 hunks)
- api/prel_api/oas_request_encoders_gen.go (1 hunks)
- api/prel_api/oas_response_decoders_gen.go (2 hunks)
- api/prel_api/oas_response_encoders_gen.go (2 hunks)
- api/prel_api/oas_router_gen.go (4 hunks)
- api/prel_api/oas_schemas_gen.go (7 hunks)
- api/prel_api/oas_server_gen.go (2 hunks)
- api/prel_api/oas_unimplemented_gen.go (2 hunks)
- api/prel_api/oas_validators_gen.go (1 hunks)
- db/query.sql (1 hunks)
- db/schema.sql (1 hunks)
- internal/gateway/postgresql/models.gen.go (1 hunks)
- internal/gateway/postgresql/query.sql.gen.go (3 hunks)
- internal/gateway/repository/iam_role_filtering.go (1 hunks)
- internal/handler/api_handler.go (2 hunks)
- internal/handler/converter.go (1 hunks)
- internal/handler/page_handler.go (1 hunks)
- internal/model/iam_role_filtering.go (1 hunks)
- internal/model/repository.go (1 hunks)
- internal/usecase/iam_role.go (1 hunks)
- internal/usecase/iam_role_test.go (1 hunks)
- internal/usecase/request.go (4 hunks)
- internal/usecase/usecase.go (2 hunks)
- internal/usecase/usecase_suite_test.go (1 hunks)
- scripts/insert-debug-query.sh (4 hunks)
- test/integration/iam_role_filtering_test.go (1 hunks)
- test/integration/iam_role_test.go (1 hunks)
- test/integration/request_test.go (4 hunks)
- test/testutil/clock.go (1 hunks)
- test/testutil/server.go (2 hunks)
- web/template/template.go (1 hunks)
- web/template/templates/_header.tpl (1 hunks)
- web/template/templates/admin_iam_role_filtering.tpl (1 hunks)
Files skipped from review as they are similar to previous changes (34)
- admin-page.html
- api/prel_api/oas_client_gen.go
- api/prel_api/oas_interfaces_gen.go
- api/prel_api/oas_parameters_gen.go
- api/prel_api/oas_request_decoders_gen.go
- api/prel_api/oas_request_encoders_gen.go
- api/prel_api/oas_response_decoders_gen.go
- api/prel_api/oas_response_encoders_gen.go
- api/prel_api/oas_router_gen.go
- api/prel_api/oas_schemas_gen.go
- api/prel_api/oas_server_gen.go
- api/prel_api/oas_unimplemented_gen.go
- api/prel_api/oas_validators_gen.go
- db/query.sql
- db/schema.sql
- internal/gateway/postgresql/models.gen.go
- internal/gateway/postgresql/query.sql.gen.go
- internal/gateway/repository/iam_role_filtering.go
- internal/handler/api_handler.go
- internal/handler/page_handler.go
- internal/model/iam_role_filtering.go
- internal/model/repository.go
- internal/usecase/iam_role.go
- internal/usecase/iam_role_test.go
- internal/usecase/usecase.go
- internal/usecase/usecase_suite_test.go
- scripts/insert-debug-query.sh
- test/integration/iam_role_filtering_test.go
- test/integration/iam_role_test.go
- test/testutil/clock.go
- test/testutil/server.go
- web/template/template.go
- web/template/templates/_header.tpl
- web/template/templates/admin_iam_role_filtering.tpl
Additional comments: 23
internal/handler/converter.go (2)
154-158: The function
convertIamRoleFilteringRulecorrectly converts amodel.IamRoleFilteringRuleto anapi.IamRoleFilteringRule. The fields are appropriately mapped, and the function is straightforward.161-166: The function
convertIamRoleFilteringRulescorrectly iterates over a slice ofmodel.IamRoleFilteringRulesand converts each element using theconvertIamRoleFilteringRulefunction. The use ofmakewith a capacity hint is a good practice for performance.internal/usecase/request.go (3)
- 50-66: The
validateRolesfunction checks if the provided roles are within the set of roles returned byGetIamRoles. The use of theslicespackage for theContainsmethod is appropriate. However, it's important to ensure thatGetIamRolesreturns a list of role names that are expected to be in the same format as the roles provided tovalidateRoles.Verification successful
The
GetIamRolesfunction iniam_role.goretrieves IAM roles, sorts them, and potentially filters them based on rule patterns. It returns the names of the roles, which are then used in thevalidateRolesfunction to check against the provided roles. The roles are returned as a sorted slice of strings, which is compatible with thevalidateRolesfunction's expectations.
- The roles are obtained from a call to
uc.c.GetIamRoles(now, projectID, user), which suggests that the roles are associated with a user and a project.- The roles are then appended to a slice
roleIDsafter accessing theNamefield of each role.- The
roleIDsslice is sorted, which would facilitate any operations that rely on order, such as binary search, though this is not directly relevant to thevalidateRolesfunction.- The function also involves a transaction that retrieves IAM role filtering rules and applies them to the
roleIDs.- The final list of role names is either the filtered list or the original
roleIDsif no filtering rules are applied.Given this information, it appears that the
GetIamRolesfunction returns role names in a format that should be directly comparable to the roles provided tovalidateRoles, as it uses theNamefield of the roles, which is likely the expected identifier for comparison.* 78-81: The call to `validateRoles` within `CreateRequest` is correctly placed within the transaction. This ensures that the role validation is part of the atomic operation, which is crucial for maintaining data integrity.Scripts Executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Verify that GetIamRoles returns role names in the expected format. ast-grep --lang go --pattern $'func ($_ *Usecase) GetIamRoles($_ context.Context, $_ string) ([]string, error) { $$$ }'Length of output: 2411
- 119-122: The call to
validateRoleswithinJudgeRequestis also correctly placed within the transaction. This ensures that the request is not judged unless the roles are valid, which is a good security practice.test/integration/request_test.go (1)
- 32-39: The mock setup for
QueryGrantableRolesis correctly configured to return a fixed set of roles. This setup is used across multiple tests, so usingAnyTimes()is appropriate to avoid repeating the setup.api/prel_api/oas_json_gen.go (13)
17-34: The implementation of
EncodeandencodeFieldsmethods forAPIIamRoleFilteringRulesGetOKstruct is correct and follows the standard pattern for JSON encoding in Go using thejxlibrary.40-107: The
Decodemethod forAPIIamRoleFilteringRulesGetOKstruct properly checks for nil receiver, iterates over the object fields, and uses a bit set to track required fields. However, ensure that theIamRoleFilteringRulesslice is not being reset unintentionally if it's meant to be appended to in other parts of the code.110-121: The
MarshalJSONandUnmarshalJSONmethods forAPIIamRoleFilteringRulesGetOKstruct are correctly implemented as wrappers around theEncodeandDecodemethods.123-136: The
Encodemethod forAPIIamRoleFilteringRulesPostOKstruct is implemented correctly, following the established pattern for JSON encoding.142-201: The
Decodemethod forAPIIamRoleFilteringRulesPostOKstruct is implemented correctly. It checks for nil receiver, iterates over the object fields, and uses a bit set to track required fields. Ensure that theIamRoleFilteringRulefield is intended to be overwritten and not appended to.204-215: The
MarshalJSONandUnmarshalJSONmethods forAPIIamRoleFilteringRulesPostOKstruct are correctly implemented as wrappers around theEncodeandDecodemethods.217-230: The
Encodemethod forAPIIamRoleFilteringRulesPostReqstruct is implemented correctly, following the established pattern for JSON encoding.236-297: The
Decodemethod forAPIIamRoleFilteringRulesPostReqstruct is implemented correctly. It checks for nil receiver, iterates over the object fields, and uses a bit set to track required fields. Ensure that thePatternfield is intended to be overwritten and not appended to.300-311: The
MarshalJSONandUnmarshalJSONmethods forAPIIamRoleFilteringRulesPostReqstruct are correctly implemented as wrappers around theEncodeandDecodemethods.1302-1319: The
Encodemethod forIamRoleFilteringRulestruct is implemented correctly, following the established pattern for JSON encoding.1326-1399: The
Decodemethod forIamRoleFilteringRulestruct is implemented correctly. It checks for nil receiver, iterates over the object fields, and uses a bit set to track required fields. Ensure that theIDandPatternfields are intended to be overwritten and not appended to.1402-1413: The
MarshalJSONandUnmarshalJSONmethods forIamRoleFilteringRulestruct are correctly implemented as wrappers around theEncodeandDecodemethods.14-315: > Note: This review was outside the patches, so it was mapped to the patch with the greatest overlap. Original lines [14-1413]
All other JSON marshaling and unmarshaling methods for the various structs in this file follow the established patterns and are correctly implemented. Ensure that all fields that are overwritten during the
Decodeprocess are intended to behave as such and are not meant to be appended to existing data.api/prel_api/oas_handlers_gen.go (4)
22-154: The implementation of
handleAPIIamRoleFilteringRulesGetRequestseems to follow the standard pattern for handling a GET request in this codebase. It includes telemetry, security checks, error handling, and response encoding. Ensure that the security checks (securityCookieAuth) and the actual business logic call (APIIamRoleFilteringRulesGet) are correctly implemented and tested.156-303: The
handleAPIIamRoleFilteringRulesPostRequestfunction follows a similar pattern to the GET request handler. It includes decoding the request, running security checks, invoking the business logic, and encoding the response. Verify that the request decoding (decodeAPIIamRoleFilteringRulesPostRequest) and the business logic (APIIamRoleFilteringRulesPost) are correctly implemented and tested.305-452: The
handleAPIIamRoleFilteringRulesRuleIDDeleteRequestfunction is responsible for handling DELETE requests. It includes parameter decoding, security checks, business logic invocation, and response encoding. Verify that the parameter decoding (decodeAPIIamRoleFilteringRulesRuleIDDeleteParams) and the business logic (APIIamRoleFilteringRulesRuleIDDelete) are correctly implemented and tested.1684-1816: The
handleAdminIamRoleFilteringGetRequestfunction is designed to handle GET requests for the admin IAM role filtering page. It follows the established pattern for request handling, including security checks and response encoding. Verify that the business logic (AdminIamRoleFilteringGet) is correctly implemented and tested, and ensure that the admin page is properly secured and only accessible to authorized users.
| Context("when request' role is not permitted", func() { | ||
| It("should return error", func() { | ||
| res, err := helper.ApiClient.APIRequestsPost(ctx, &api.APIRequestsPostReq{ | ||
| ProjectID: "project-id", | ||
| IamRoles: []string{ | ||
| "roles/bigquery.admin", | ||
| }, | ||
| Period: api.APIRequestsPostReqPeriod10, | ||
| Reason: "this is a test", | ||
| }) | ||
|
|
||
| Expect(err).NotTo(HaveOccurred()) | ||
| Expect(res).NotTo(BeNil()) | ||
| Expect(res.(*api.BadRequest)).NotTo(BeNil()) | ||
|
|
||
| b, err := io.ReadAll(res.(*api.BadRequest).Data) | ||
| Expect(err).NotTo(HaveOccurred()) | ||
| Expect(string(b)).To(ContainSubstring("Invalid Argument")) | ||
| }) | ||
| }) |
There was a problem hiding this comment.
The new test case "when request' role is not permitted" should verify that the error returned when an invalid role is used is as expected. However, the test expects a BadRequest response, which is not consistent with the expected behavior of returning an error when roles are not permitted. The test should assert the specific error type and message related to invalid roles.
- Expect(res.(*api.BadRequest)).NotTo(BeNil())
+ Expect(res).To(BeAssignableToTypeOf(api.ErrorResponse{}))
+ Expect(res.(api.ErrorResponse).GetMessage()).To(ContainSubstring("invalid iam role"))Committable suggestion
❗ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.
| Context("when request' role is not permitted", func() { | |
| It("should return error", func() { | |
| res, err := helper.ApiClient.APIRequestsPost(ctx, &api.APIRequestsPostReq{ | |
| ProjectID: "project-id", | |
| IamRoles: []string{ | |
| "roles/bigquery.admin", | |
| }, | |
| Period: api.APIRequestsPostReqPeriod10, | |
| Reason: "this is a test", | |
| }) | |
| Expect(err).NotTo(HaveOccurred()) | |
| Expect(res).NotTo(BeNil()) | |
| Expect(res.(*api.BadRequest)).NotTo(BeNil()) | |
| b, err := io.ReadAll(res.(*api.BadRequest).Data) | |
| Expect(err).NotTo(HaveOccurred()) | |
| Expect(string(b)).To(ContainSubstring("Invalid Argument")) | |
| }) | |
| }) | |
| Context("when request' role is not permitted", func() { | |
| It("should return error", func() { | |
| res, err := helper.ApiClient.APIRequestsPost(ctx, &api.APIRequestsPostReq{ | |
| ProjectID: "project-id", | |
| IamRoles: []string{ | |
| "roles/bigquery.admin", | |
| }, | |
| Period: api.APIRequestsPostReqPeriod10, | |
| Reason: "this is a test", | |
| }) | |
| Expect(err).NotTo(HaveOccurred()) | |
| Expect(res).NotTo(BeNil()) | |
| Expect(res).To(BeAssignableToTypeOf(api.ErrorResponse{})) | |
| Expect(res.(api.ErrorResponse).GetMessage()).To(ContainSubstring("invalid iam role")) | |
| b, err := io.ReadAll(res.(*api.BadRequest).Data) | |
| Expect(err).NotTo(HaveOccurred()) | |
| Expect(string(b)).To(ContainSubstring("Invalid Argument")) | |
| }) | |
| }) |
| Context("when request has invalid role", func() { | ||
| It("should return error", func() { | ||
| newReq := testutil.NewRequest(testutil.WithRequesterUserID(helper.User.ID()), testutil.WithIamRoles([]string{"invalid-role"})) | ||
| Expect(helper.RequestRepo.Save(ctx, newReq)).To(Succeed()) | ||
|
|
||
| res, err := judgerClient.APIRequestsRequestIDPatch(ctx, &api.APIRequestsRequestIDPatchReq{ | ||
| Status: api.JudgeStatusApprove, | ||
| }, api.APIRequestsRequestIDPatchParams{ | ||
| RequestID: newReq.ID(), | ||
| }) | ||
|
|
||
| Expect(err).NotTo(HaveOccurred()) | ||
| Expect(res).NotTo(BeNil()) | ||
|
|
||
| b, err := io.ReadAll(res.(*api.BadRequest).Data) | ||
| Expect(err).NotTo(HaveOccurred()) | ||
| Expect(string(b)).To(ContainSubstring("Invalid Argument")) | ||
| }) | ||
| }) |
There was a problem hiding this comment.
The test case "when request has invalid role" is similar to the previous one and should also assert the specific error type and message related to invalid roles. The same issue applies here.
- Expect(res.(*api.BadRequest)).NotTo(BeNil())
+ Expect(res).To(BeAssignableToTypeOf(api.ErrorResponse{}))
+ Expect(res.(api.ErrorResponse).GetMessage()).To(ContainSubstring("invalid iam role"))Committable suggestion
❗ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.
| Context("when request has invalid role", func() { | |
| It("should return error", func() { | |
| newReq := testutil.NewRequest(testutil.WithRequesterUserID(helper.User.ID()), testutil.WithIamRoles([]string{"invalid-role"})) | |
| Expect(helper.RequestRepo.Save(ctx, newReq)).To(Succeed()) | |
| res, err := judgerClient.APIRequestsRequestIDPatch(ctx, &api.APIRequestsRequestIDPatchReq{ | |
| Status: api.JudgeStatusApprove, | |
| }, api.APIRequestsRequestIDPatchParams{ | |
| RequestID: newReq.ID(), | |
| }) | |
| Expect(err).NotTo(HaveOccurred()) | |
| Expect(res).NotTo(BeNil()) | |
| b, err := io.ReadAll(res.(*api.BadRequest).Data) | |
| Expect(err).NotTo(HaveOccurred()) | |
| Expect(string(b)).To(ContainSubstring("Invalid Argument")) | |
| }) | |
| }) | |
| Context("when request has invalid role", func() { | |
| It("should return error", func() { | |
| newReq := testutil.NewRequest(testutil.WithRequesterUserID(helper.User.ID()), testutil.WithIamRoles([]string{"invalid-role"})) | |
| Expect(helper.RequestRepo.Save(ctx, newReq)).To(Succeed()) | |
| res, err := judgerClient.APIRequestsRequestIDPatch(ctx, &api.APIRequestsRequestIDPatchReq{ | |
| Status: api.JudgeStatusApprove, | |
| }, api.APIRequestsRequestIDPatchParams{ | |
| RequestID: newReq.ID(), | |
| }) | |
| Expect(err).NotTo(HaveOccurred()) | |
| Expect(res).To(BeAssignableToTypeOf(api.ErrorResponse{})) | |
| Expect(res.(api.ErrorResponse).GetMessage()).To(ContainSubstring("invalid iam role")) | |
| }) | |
| }) |
Summary by CodeRabbit
New Features
Improvements
Bug Fixes
Documentation
Testing
User Interface
Database