Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: sunitaize user input #56

Merged
merged 3 commits into from
Jan 11, 2024
Merged

bugfix: sunitaize user input #56

merged 3 commits into from
Jan 11, 2024

Conversation

lirlia
Copy link
Owner

@lirlia lirlia commented Jan 10, 2024

restrict user input like (<, >)

Summary by CodeRabbit

  • New Features

    • Implemented input sanitization across various components to enhance security against cross-site scripting (XSS) attacks.
    • Added a middleware to limit and sanitize incoming HTTP request bodies.
  • Bug Fixes

    • Escaped special characters in admin panel input fields to prevent potential security vulnerabilities.

Copy link

coderabbitai bot commented Jan 10, 2024

Walkthrough

The recent update enhances security by introducing a middleware that sanitizes incoming HTTP requests to prevent XSS attacks. It limits the size of request bodies and escapes certain characters in POST, PUT, and PATCH methods. Additionally, JavaScript files have been updated to escape HTML tags, further safeguarding the application from potential injection vulnerabilities.

Changes

File Path Change Summary
pkg/middleware/sanitizer.go
pkg/middleware/sanitizer_test.go
Introduces the Sanitizer middleware to limit request body size and sanitize input.
static/js/admin_iam_role_filtering.js
static/js/admin_user.js
static/js/request_form.js
Implements input sanitation for HTML tags in various JavaScript files.

Poem

🐇 "In the realm of code, we hop and stride,
🌐 Through servers and scripts, we deftly glide.
🛡️ With each sanitizing sweep, we cast,
📜 XSS fears into the past."

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit-tests for this file.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit tests for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository from git and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit tests.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 4

Configuration used: .coderabbit.yaml

Commits Files that changed from the base of the PR and between 008d176 and f727fc0.
Files selected for processing (6)
  • internal/server/server.go (1 hunks)
  • pkg/middleware/sanitizer.go (1 hunks)
  • pkg/middleware/sanitizer_test.go (1 hunks)
  • static/js/admin_iam_role_filtering.js (1 hunks)
  • static/js/admin_user.js (2 hunks)
  • static/js/request_form.js (1 hunks)
Files skipped from review due to trivial changes (2)
  • internal/server/server.go
  • static/js/admin_user.js

pkg/middleware/sanitizer.go Outdated Show resolved Hide resolved
static/js/admin_iam_role_filtering.js Outdated Show resolved Hide resolved
pkg/middleware/sanitizer_test.go Outdated Show resolved Hide resolved
static/js/request_form.js Outdated Show resolved Hide resolved
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 0

Configuration used: .coderabbit.yaml

Commits Files that changed from the base of the PR and between f727fc0 and f202999.
Files selected for processing (3)
  • pkg/middleware/sanitizer.go (1 hunks)
  • static/js/admin_iam_role_filtering.js (1 hunks)
  • static/js/request_form.js (1 hunks)
Files skipped from review as they are similar to previous changes (3)
  • pkg/middleware/sanitizer.go
  • static/js/admin_iam_role_filtering.js
  • static/js/request_form.js

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 0

Configuration used: .coderabbit.yaml

Commits Files that changed from the base of the PR and between f727fc0 and cd75be6.
Files selected for processing (4)
  • pkg/middleware/sanitizer.go (1 hunks)
  • pkg/middleware/sanitizer_test.go (1 hunks)
  • static/js/admin_iam_role_filtering.js (1 hunks)
  • static/js/request_form.js (1 hunks)
Files skipped from review as they are similar to previous changes (4)
  • pkg/middleware/sanitizer.go
  • pkg/middleware/sanitizer_test.go
  • static/js/admin_iam_role_filtering.js
  • static/js/request_form.js

@lirlia lirlia merged commit c2904b9 into main Jan 11, 2024
5 checks passed
@lirlia lirlia deleted the bugfix/add-sanitizer branch January 11, 2024 01:22
@prel-bot prel-bot bot mentioned this pull request Jan 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant