Discussion - rename ViewHolder classes to GroupieViewHolder

[ValCanBuild]

I'd like to start making more quality of life improvements in the library. One thing that I find annoying as a user is the fact that the Groupie ViewHolder class shares a name with the actual platform one.

My proposal is to rename it GroupieViewHolder. Ideally I'd also like to rename the databinding and kotlin-android-extensions versions to something else as well but I don't have any great name ideas. Would anyone have any suggestions?

Please comment here with your thoughts on this.

[Zhuinden]

My typealias was also called GroupieViewHolder for similar reasons, I think it's a good idea overall.

[DarrenAtherton49]

Upvote for GroupieViewHolder. What is the reasoning behind the databinding and kotlin-android-extensions` renaming?

[ValCanBuild]

@DarrenAtherton49 Its a more minor annoyance but the fact they all share a class name makes it less clear which one is used and can lead to errors/frustrations when importing. If you use the main library + either the databinding or kotlin extension one then you end up with 2 things named the same way.

[ValCanBuild]

PR created #293

[ValCanBuild]

Now deployed in 2.6.0. Thank you for your feedback