-
Notifications
You must be signed in to change notification settings - Fork 293
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Discussion - rename ViewHolder classes to GroupieViewHolder #287
Comments
My typealias was also called |
Upvote for |
@DarrenAtherton49 Its a more minor annoyance but the fact they all share a class name makes it less clear which one is used and can lead to errors/frustrations when importing. If you use the main library + either the databinding or kotlin extension one then you end up with 2 things named the same way. |
PR created #293 |
Now deployed in |
I'd like to start making more quality of life improvements in the library. One thing that I find annoying as a user is the fact that the Groupie
ViewHolder
class shares a name with the actual platform one.My proposal is to rename it
GroupieViewHolder
. Ideally I'd also like to rename thedatabinding
andkotlin-android-extensions
versions to something else as well but I don't have any great name ideas. Would anyone have any suggestions?Please comment here with your thoughts on this.
The text was updated successfully, but these errors were encountered: