Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New getting started doc #969

Merged
merged 2 commits into from
Apr 27, 2020
Merged

New getting started doc #969

merged 2 commits into from
Apr 27, 2020

Conversation

arthurevans
Copy link
Contributor

@arthurevans arthurevans commented Apr 20, 2020

New draft getting started doc. Staged at:

https://new-getting-started-dot-polymer-lit-element.appspot.com

Leaving this PR open for feedback until Friday, 4/24.

@arthurevans arthurevans changed the title New getting started doc. New getting started doc [Draft--do not merge] Apr 20, 2020
docs/_guide/start.md Show resolved Hide resolved
docs/_guide/start.md Outdated Show resolved Hide resolved
docs/_guide/start.md Outdated Show resolved Hide resolved
docs/_guide/start.md Outdated Show resolved Hide resolved
docs/_guide/start.md Show resolved Hide resolved
docs/_guide/start.md Show resolved Hide resolved
docs/_guide/start.md Outdated Show resolved Hide resolved
docs/_guide/start.md Outdated Show resolved Hide resolved
docs/_guide/start.md Outdated Show resolved Hide resolved
@dman777
Copy link

dman777 commented Apr 22, 2020

Although I do not see it in this PR, I will mention it here since it is in the context:

In the example for events in docs:

class MyElement extends LitElement {
  render() {
    return html`<div>Hello World</div>`;
  }
  updated(changedProperties) {
    let click = new Event('click');
    this.dispatchEvent(click);
  }
}

Specifically, in let click = new Event('click').... this is incorrect JS. If click is not going to get reassigned so it should be using const.

Proof:

> const foo = { pie: 'apple' }
undefined
> foo.pie = 'blueberry';
'blueberry'
> foo = 'not going to happen';
Thrown:
TypeError: Assignment to constant variable.

@abdonrd
Copy link
Contributor

abdonrd commented Apr 23, 2020

@arthurevans as the PR is a draft, you can convert it here instead of adding draft to the title 😄

Screenshot 2020-04-23 at 18 07 08

@arthurevans arthurevans marked this pull request as draft April 23, 2020 17:20
@arthurevans arthurevans changed the title New getting started doc [Draft--do not merge] New getting started doc Apr 23, 2020
@arthurevans
Copy link
Contributor Author

I swear I looked all over for that UI before I just gave up and edited the title, @abdonrd 😂

@arthurevans
Copy link
Contributor Author

@dman777 you're right, but it seems unrelated... Do you want to open a PR?

@arthurevans arthurevans marked this pull request as ready for review April 24, 2020 23:31
@arthurevans
Copy link
Contributor Author

Addressed feedback and restaged. Unless someone sees a showstopper, I'll roll this out Monday.

@arthurevans arthurevans merged commit 503e660 into master Apr 27, 2020
@arthurevans arthurevans deleted the get-started branch April 27, 2020 16:37
@arthurevans
Copy link
Contributor Author

Thanks for all the great feedback, folks! Update is live.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants