[infra] Use latest kaniko executor image for cloudbuild #1143
Conversation
|
A live preview of this PR will be available at the URL(s) below. |
|
If the preview deploy works does this verify that the change worked? Thank you! |
Yes the failing build step is practically identical for prod build and preview build so as it looks like it made it past the build step, I have confidence this should work for prod build as well. No risk if it somehow fails after merging as that's no worse than where we're currently at and we'll just be serving the site from an older version. |
| @@ -9,9 +9,7 @@ steps: | |||
| # https://github.com/GoogleCloudPlatform/cloud-builders/tree/master/docker | |||
| # https://cloud.google.com/build/docs/kaniko-cache | |||
| - id: build | |||
| # Kaniko pinned to earlier version due to | |||
There was a problem hiding this comment.
Is it worth pinning to the latest specific version so that it doesn't update out from under us?
There was a problem hiding this comment.
I had considered that, but figured it'd be fine to get the benefit of auto update versus the risk of some version breaking us. We didn't have it pinned prior to the issue in comment.
|
Prod build and deploy was successful with this and I can see the typo fix of the previously merged PR (with the failing build) applied in the live site. |
The issue mentioned in the comment with the version pinning GoogleContainerTools/kaniko#1786 has been fixed.
Our production build started failing though and seems kaniko related. The error shown in GCP is the same as GoogleContainerTools/kaniko#1604
Not sure why we just started seeing this now, but trying to see if using the latest version fixes this.