Skip to content
This repository has been archived by the owner on Sep 16, 2021. It is now read-only.

Commit

Permalink
Updated Mocha to latest version, resolved critical package bugs from …
Browse files Browse the repository at this point in the history
…old Mocha version.

Discovered new bugs in tests: test/scaffold/create.integration.js (fixed now)
  • Loading branch information
Edin Jusupovic committed Aug 23, 2018
1 parent e1a3fcf commit 5c9e508
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
4 changes: 2 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@
"litecoind"
],
"peerDependencies": {
"litecore-lib": "^0.13.22"
"litecore-lib": "^0.13.22"
},
"dependencies": {
"async": "^1.3.0",
Expand Down Expand Up @@ -83,7 +83,7 @@
"istanbul": "^0.4.3",
"jshint": "^2.9.2",
"jshint-stylish": "^2.1.0",
"mocha": "^2.4.5",
"mocha": "^5.2.0",
"proxyquire": "^1.3.1",
"rimraf": "^2.4.2",
"sinon": "^1.15.4"
Expand Down
4 changes: 2 additions & 2 deletions test/scaffold/create.integration.js
Original file line number Diff line number Diff line change
Expand Up @@ -71,8 +71,8 @@ describe('#create', function() {
should.equal(fs.existsSync(packagePath), true);

var config = JSON.parse(fs.readFileSync(configPath));
config.services.should.deep.equal(['bitcoind', 'db', 'address', 'web']);
config.datadir.should.equal('./data');
config.services.should.deep.equal(['bitcoind', 'web']);
config.servicesConfig.bitcoind.spawn.datadir.should.equal('./data');
config.network.should.equal('livenet');

var pack = JSON.parse(fs.readFileSync(packagePath));
Expand Down

1 comment on commit 5c9e508

@backcopy
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check on line 74 was failing even before the Mocha v5 upgrade, unsure how or why this was passing, appears to be some sort of bug. See runtime below.

screen shot 2018-08-23 at 12 11 01 pm

Please sign in to comment.