Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Limit sdk based on api config #65

Merged
merged 12 commits into from
Nov 30, 2022
Merged

Limit sdk based on api config #65

merged 12 commits into from
Nov 30, 2022

Conversation

antho1404
Copy link
Member

@antho1404 antho1404 commented Oct 29, 2022 •
edited
Loading

Project organization

Description

Update hooks to raise an error if the API does not has the feature enabled rather than calling the API and failing anyway

How to test

Run the API without the plugins you want to test and test that the hooks fail correctly

Checklist

  • Update related changelogs
  • Update docs if necessary

@vercel
Copy link

vercel bot commented Oct 29, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
docs ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Nov 30, 2022 at 3:42AM (UTC)
storybook-components ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Nov 30, 2022 at 3:42AM (UTC)
storybook-templates ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Nov 30, 2022 at 3:42AM (UTC)

@vercel vercel bot temporarily deployed to Preview – storybook-templates October 29, 2022 06:39 Inactive
@antho1404 antho1404 self-assigned this Oct 29, 2022
@antho1404 antho1404 changed the title Feature/limit sdk based on api config Limit sdk based on api config Oct 29, 2022
@vercel vercel bot temporarily deployed to Preview – storybook-components October 29, 2022 06:44 Inactive
@vercel vercel bot temporarily deployed to Preview – storybook-templates October 29, 2022 06:46 Inactive
@vercel vercel bot temporarily deployed to Preview – docs November 26, 2022 14:23 Inactive
@vercel vercel bot temporarily deployed to Preview – storybook-components November 26, 2022 14:25 Inactive
@vercel vercel bot temporarily deployed to Preview – storybook-templates November 26, 2022 14:27 Inactive
@vercel vercel bot temporarily deployed to Preview – docs November 26, 2022 14:30 Inactive
@vercel vercel bot temporarily deployed to Preview – storybook-templates November 26, 2022 14:35 Inactive
@vercel vercel bot temporarily deployed to Preview – storybook-components November 26, 2022 14:39 Inactive
@vercel vercel bot temporarily deployed to Preview – storybook-components November 27, 2022 06:26 Inactive
@antho1404 antho1404 marked this pull request as ready for review November 27, 2022 06:26
@vercel vercel bot temporarily deployed to Preview – docs November 27, 2022 06:29 Inactive
@vercel vercel bot temporarily deployed to Preview – storybook-templates November 27, 2022 06:32 Inactive
@vercel vercel bot temporarily deployed to Preview – storybook-components November 27, 2022 06:34 Inactive
@cpvdeveloper
Copy link
Contributor

Good idea 👍

@vercel vercel bot temporarily deployed to Preview – storybook-templates November 30, 2022 03:37 Inactive
@vercel vercel bot temporarily deployed to Preview – docs November 30, 2022 03:40 Inactive
@vercel vercel bot temporarily deployed to Preview – storybook-components November 30, 2022 03:42 Inactive
@antho1404 antho1404 merged commit 3dd3283 into main Nov 30, 2022
@antho1404 antho1404 deleted the feature/limit-sdk-based-on-api-config branch November 30, 2022 03:42
@antho1404 antho1404 mentioned this pull request Dec 2, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cpvdeveloper cpvdeveloper cpvdeveloper approved these changes

@NicolasMahe NicolasMahe Awaiting requested review from NicolasMahe

Assignees

@antho1404 antho1404

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@antho1404 @cpvdeveloper