Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup error management with ts-invariant #64

Merged
merged 8 commits into from
Oct 31, 2022
Merged

Cleanup error management with ts-invariant #64

merged 8 commits into from
Oct 31, 2022

Conversation

antho1404
Copy link
Member

Description

Cleanup the codebase of the hooks:

  • Remove useless checks (because we now use the graphql request
  • Centralize error messages in an error.ts file
  • Use ts-invariant to simplify the codebase and replace all the if() throw new Error()

@vercel
Copy link

vercel bot commented Oct 28, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
storybook-components ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Oct 31, 2022 at 9:04AM (UTC)
storybook-templates ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Oct 31, 2022 at 9:04AM (UTC)

@vercel vercel bot temporarily deployed to Preview – storybook-components October 28, 2022 20:04 Inactive
@vercel vercel bot temporarily deployed to Preview – storybook-templates October 28, 2022 20:06 Inactive
@vercel vercel bot temporarily deployed to Preview – storybook-components October 28, 2022 20:12 Inactive
@vercel vercel bot temporarily deployed to Preview – storybook-templates October 28, 2022 20:17 Inactive
@antho1404 antho1404 marked this pull request as ready for review October 29, 2022 06:21
@vercel vercel bot temporarily deployed to Preview – storybook-templates October 29, 2022 06:24 Inactive
@vercel vercel bot temporarily deployed to Preview – storybook-components October 29, 2022 06:27 Inactive
@antho1404 antho1404 mentioned this pull request Oct 29, 2022
Merged
2 tasks
@vercel vercel bot temporarily deployed to Preview – storybook-components October 31, 2022 03:46 Inactive
@vercel vercel bot temporarily deployed to Preview – storybook-templates October 31, 2022 03:51 Inactive
@achampagnedev
Copy link
Contributor

Does it make more sense to rename ErrorCodes into ErrorMessages ?

@antho1404
Copy link
Member Author

Good catch, all renamed ;)

@vercel vercel bot temporarily deployed to Preview – storybook-templates October 31, 2022 06:03 Inactive
@vercel vercel bot temporarily deployed to Preview – storybook-components October 31, 2022 06:16 Inactive
@achampagnedev
Copy link
Contributor

Turborepo crash issue but code is ok

@antho1404 antho1404 enabled auto-merge October 31, 2022 08:49
@antho1404
Copy link
Member Author

Had some issue while generating the package-lock, this has been fixed

@vercel vercel bot temporarily deployed to Preview – storybook-components October 31, 2022 08:54 Inactive
@vercel vercel bot temporarily deployed to Preview – storybook-templates October 31, 2022 09:04 Inactive
@antho1404 antho1404 merged commit 46d3abe into main Oct 31, 2022
@antho1404 antho1404 deleted the feature/cleanup-error-management branch October 31, 2022 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@achampagnedev achampagnedev achampagnedev approved these changes

@cpvdeveloper cpvdeveloper Awaiting requested review from cpvdeveloper

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@antho1404 @achampagnedev