-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Core package base -- placeBid and listToken #142
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NicolasMahe
reviewed
Mar 22, 2023
NicolasMahe
reviewed
Mar 22, 2023
NicolasMahe
reviewed
Mar 22, 2023
NicolasMahe
reviewed
Mar 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR creates the foundation for the new
@liteflow/core
package that will provide all the features associated with the API but any javascript/typescript application. This will complement the current@nft/react
that can only be used in react.The goal is that
@nft/react
will use@liteflow/core
and eventually be renamed.In this PR, I only focused on the general architecture and the creation of offers with
Regarding architecture, we have a general client with modules like the exchange with specific actions.
This can be initialized like
I also updated the hook library to initialize this client (for now alongside the other existing client) and use the core lib to execute the actions in the
useCreateOffer
How to test
Build the library and play with some scripts or update the starter kit by linking these libraries and trying to create a new listing and/or a new bid.
Checklist