Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Core package base -- placeBid and listToken #142

Merged
merged 18 commits into from
May 31, 2023

Conversation

antho1404
Copy link
Member

Description

This PR creates the foundation for the new @liteflow/core package that will provide all the features associated with the API but any javascript/typescript application. This will complement the current @nft/react that can only be used in react.
The goal is that @nft/react will use @liteflow/core and eventually be renamed.

In this PR, I only focused on the general architecture and the creation of offers with

  • placeBid
  • listToken

Regarding architecture, we have a general client with modules like the exchange with specific actions.
This can be initialized like

new Client(new URL('https://...')).exchange.placeBid(...)

I also updated the hook library to initialize this client (for now alongside the other existing client) and use the core lib to execute the actions in the useCreateOffer

How to test

Build the library and play with some scripts or update the starter kit by linking these libraries and trying to create a new listing and/or a new bid.

Checklist

  • Update related changelogs
  • Update docs if necessary

@antho1404 antho1404 self-assigned this Mar 20, 2023
packages/core/codegen.yml Outdated Show resolved Hide resolved
packages/hooks/package.json Outdated Show resolved Hide resolved
packages/core/src/client.ts Show resolved Hide resolved
packages/core/src/exchange/index.ts Outdated Show resolved Hide resolved
packages/core/src/types.ts Outdated Show resolved Hide resolved
packages/core/src/utils/convert.ts Outdated Show resolved Hide resolved
@antho1404 antho1404 merged commit 8ae00a5 into sdk-v1 May 31, 2023
@antho1404 antho1404 deleted the feature/core-package-base branch May 31, 2023 08:19
@antho1404 antho1404 mentioned this pull request May 31, 2023
19 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants