Added option to see a brand note in the footer #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
antho1404
approved these changes
Nov 1, 2022
There was a problem hiding this comment.
If design is good for @EmmanuelDrouin it's good for me.
Naming might be improved showBrandNote, I would have put something more like showPoweredBy so there is no mental conversion but not a big issue
|
Just switched naming to |
Yep design is good for me |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Project organization
Description
The goal of this PR is to add the option to see a brand note "Powered By" in the Footer
added property
showBrandNoteto footer to enable this functionality.How to test
See Storybook in the Footer section story
With Brand Notehttps://storybook-components-clsttr3th-liteflow.vercel.app/?path=/story/templates-footer-footer--with-brand-note
Checklist