Update library with removal of session and delegation of providers to app #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vercel
bot
temporarily deployed
to
Preview – nft-test-polygon-mumbai
vercel
bot
temporarily deployed
to
Preview – nft-test-polygon-mumbai
vercel
bot
temporarily deployed
to
Preview – nft-test-polygon-mumbai
vercel
bot
temporarily deployed
to
Preview – nft-test-polygon-mumbai
2 tasks
antho1404
changed the title
Merged
cpvdeveloper
reviewed
Dec 6, 2022
cpvdeveloper
reviewed
Dec 6, 2022
vercel
bot
temporarily deployed
to
Preview – nft-test-polygon-mumbai
2 tasks
|
I updated the branch to merge into feature/app-template-merge as the build is failing because of some modification that requires to re-publish the library of templates but in the next PR the library or template will be completely gone so we can have a final full review on the feature/app-template-merge branch when ready |
This was referenced Dec 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dependency: liteflow-labs/liteflow-js#90
Related: #46
This dependency is easier to review in parallel with liteflow-labs/liteflow-js#90 and follow the commit history.
This uses the latest version of the library that removes the session and most of the providers in the general context.
Thanks to that, the application can now define the web3 provider/connectors, the way to store the authenticated user (session / cookies), handle the user's authentication...
The application is now also responsible to reconnect the user's wallet with the eagerConnect still with the goal that it become the application's responsibility to handle the wallet of its choice