Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Remove unnecessary includeWhenCollectionDeleted flag in navbar and notification gql files #604

Merged
merged 1 commit into from
Aug 11, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion layouts/navbar.gql
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@ query NavbarAccount($account: Address!, $lastNotification: Datetime!) {
}
notifications(
condition: { after: $lastNotification }
includeWhenCollectionDeleted: YES
includeWhenTradeDeleted: YES
) {
totalCount
Expand Down
1 change: 0 additions & 1 deletion pages/notification.gql
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
query GetNotifications($limit: Int!, $offset: Int!) {

Check warning on line 1 in pages/notification.gql

View workflow job for this annotation

GitHub Actions / lint

Operation "GetNotifications" should not have "Get" prefix
notifications(
condition: {
actions: [
Expand All @@ -14,7 +14,6 @@
first: $limit
orderBy: CREATED_AT_DESC
offset: $offset
includeWhenCollectionDeleted: YES
includeWhenTradeDeleted: YES
) {
pageInfo {
Expand Down
Loading