Conflict with LiteBans

[Artuto]

Hi, I was testing my mute command and I noticed this plugin has a incompatibillity when a player is muted this plugin allows them to still chat. Could you fix it?

[Artuto]

Maybe a hook on the LiteBans API which checks if the user is muted

[literalplus]

That definitely sounds like very weird behaviour – This plugin shouldn't touch non-command chat messages at all. I didn't know it could do that. Could you please provide a full plugins list and links to the relevant plugins? I assume you have made sure that it's really my plugin that's causing the issue?

…

On Sun, 21 Jan 2018, 21:06 Artuto, ***@***.***> wrote: Maybe a hook on the LiteBans API which checks if the user is muted — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#38 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAhY_u1qn2NVbcDqv2GpE0OvvRBr27dCks5tM5jFgaJpZM4Rl8eK> .

[Artuto]

From what I saw on LiteBans' wiki is a known incompatibility (https://github.com/ruany/LiteBans)

[Artuto]

https://cdn.discordapp.com/attachments/323954859713888256/404815340602785812/Capture_2018-01-21-19-51-03.png

FAQ wiki page

[literalplus]

Thanks for the clarification that you're using the plugin on BungeeCord. It looks like LiteBans is a premium resource and does not publish its source code. Therefore I am unable to reproduce the issue. Generally, my policy is that incompatible proprietary plugins need cooperation from the author, since there is no other way I can resolve issues related to them: I neither have the code that's causing the issue nor anything to test it with. However, I'll take a quick look at the related code later today, to see if there's any obvious errors that jump to my eye. If not, I probably need more technical and detailed information on how the plugin works, which for proprietary plugins is usually only known to the author. (or a free plugin which has the same issue)

…

On Mon, 22 Jan 2018, 02:52 Artuto, ***@***.***> wrote: https://cdn.discordapp.cbom/attachments/323954859713888256/404815340602785812/Capture_2018-01-21-19-51-03.png <https://cdn.discordapp.com/attachments/323954859713888256/404815340602785812/Capture_2018-01-21-19-51-03.png> FAQ wiki page — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#38 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAhY_ojE8NqDGC3Lf1OlgGnGDZBWjevLks5tM-nGgaJpZM4Rl8eK> .

[literalplus]

Okay, nevermind, I see what the issue is 🙄 I'll push a fix shortly. Sorry for the inconvenience.

…

On Mon, 22 Jan 2018, 11:09 Philipp Nowak, ***@***.***> wrote: Thanks for the clarification that you're using the plugin on BungeeCord. It looks like LiteBans is a premium resource and does not publish its source code. Therefore I am unable to reproduce the issue. Generally, my policy is that incompatible proprietary plugins need cooperation from the author, since there is no other way I can resolve issues related to them: I neither have the code that's causing the issue nor anything to test it with. However, I'll take a quick look at the related code later today, to see if there's any obvious errors that jump to my eye. If not, I probably need more technical and detailed information on how the plugin works, which for proprietary plugins is usually only known to the author. (or a free plugin which has the same issue) On Mon, 22 Jan 2018, 02:52 Artuto, ***@***.***> wrote: > > https://cdn.discordapp.cbom/attachments/323954859713888256/404815340602785812/Capture_2018-01-21-19-51-03.png > <https://cdn.discordapp.com/attachments/323954859713888256/404815340602785812/Capture_2018-01-21-19-51-03.png> > FAQ wiki page > > — > You are receiving this because you commented. > > > Reply to this email directly, view it on GitHub > <#38 (comment)>, > or mute the thread > <https://github.com/notifications/unsubscribe-auth/AAhY_ojE8NqDGC3Lf1OlgGnGDZBWjevLks5tM-nGgaJpZM4Rl8eK> > . >

[literalplus]

Thanks for reporting this issue. Please try this build which should fix your issue: https://ci.l1t.li/job/public~cmdblkult/77/

I'll publish a release to SpigotMC once you confirm that this fixes the issue.

[Artuto]

One thing, that version/jar is the Bukkit one, that means is a Bukkit-Side issue?

[literalplus]

It's a BungeeCord-only issue. CBU uses "universal" jars that work for both platforms.

[Artuto]

Yeah just noticed...

[literalplus]

Changed the naming to [Universal] now :)

[Artuto]

Tested and works fine, you can close and push the update to SMC 😀

[literalplus]

Awesome! Thanks for your report and quick replies! :)

[Artuto]

Thank you for the quick fix!