Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: close RedisStore client in case the with_client classmethod is used #3111

Merged
merged 32 commits into from
Feb 27, 2024
Merged

fix: close RedisStore client in case the with_client classmethod is used #3111

merged 32 commits into from
Feb 27, 2024

Commits on Feb 13, 2024

  1. Added store lifetime note

    @euri10
    euri10 committed Feb 13, 2024
    Configuration menu
    Copy the full SHA
    1630f5b View commit details
    Browse the repository at this point in the history

  2. Added failing test from issue, will write a "simpler" one after hopef… 

    …ully
    @euri10
    euri10 committed Feb 13, 2024
    Configuration menu
    Copy the full SHA
    c800ff7 View commit details
    Browse the repository at this point in the history

Commits on Feb 14, 2024

  1. Make the RedisStore a context manager and see

    @euri10
    euri10 committed Feb 14, 2024
    Configuration menu
    Copy the full SHA
    0523767 View commit details
    Browse the repository at this point in the history

  2. Implement those good suggstions 

    Note that close_connection_pool is required
    @euri10
    euri10 committed Feb 14, 2024
    Configuration menu
    Copy the full SHA
    8650cb6 View commit details
    Browse the repository at this point in the history

  3. Better naming for the boolean that decides if we should handle stuff … 

    …manually or not

Co-authored-by: Janek Nouvertné <provinzkraut@posteo.de>
    @euri10 @provinzkraut
    euri10 and provinzkraut authored Feb 14, 2024
    Configuration menu
    Copy the full SHA
    6f56678 View commit details
    Browse the repository at this point in the history

  4. Removed the classmethod arg 

    Co-authored-by: Janek Nouvertné <provinzkraut@posteo.de>
    @euri10 @provinzkraut
    euri10 and provinzkraut authored Feb 14, 2024
    Configuration menu
    Copy the full SHA
    bfe8262 View commit details
    Browse the repository at this point in the history

  5. Make the async context manager not abstract

    @euri10
    euri10 committed Feb 14, 2024
    Configuration menu
    Copy the full SHA
    3cb8b3f View commit details
    Browse the repository at this point in the history

  6. No need to implement __aenter__ anymore

    @euri10
    euri10 committed Feb 14, 2024
    Configuration menu
    Copy the full SHA
    3da05e5 View commit details
    Browse the repository at this point in the history

  7. Fix from previous changes and rebase

    @euri10
    euri10 committed Feb 14, 2024
    Configuration menu
    Copy the full SHA
    f732783 View commit details
    Browse the repository at this point in the history

  8. Make the bool coherent with the docstring

    @euri10
    euri10 committed Feb 14, 2024
    Configuration menu
    Copy the full SHA
    18c4aba View commit details
    Browse the repository at this point in the history

  9. Avoid linter B027 empty-method-without-abstract-decorator on purpose

    @euri10
    euri10 committed Feb 14, 2024
    Configuration menu
    Copy the full SHA
    702d5ef View commit details
    Browse the repository at this point in the history

  10. Always add the store to lifespan_manager then let the store implement… 

    …ation decides to handle to close or not
    @euri10
    euri10 committed Feb 14, 2024
    Configuration menu
    Copy the full SHA
    545fe54 View commit details
    Browse the repository at this point in the history

  11. Tamed mypy, aclose is definitely a Redis method, so not sure why it i… 

    …sn't recognized, we use types-redis
    @euri10
    euri10 committed Feb 14, 2024
    Configuration menu
    Copy the full SHA
    77ac9c0 View commit details
    Browse the repository at this point in the history

  12. Ruff stuff

    @euri10
    euri10 committed Feb 14, 2024
    Configuration menu
    Copy the full SHA
    92d3516 View commit details
    Browse the repository at this point in the history

  13. Mypy on tests 

    Added some small notes on the test since its setup is rather cumbersome
    @euri10
    euri10 committed Feb 14, 2024
    Configuration menu
    Copy the full SHA
    98ad6c8 View commit details
    Browse the repository at this point in the history

  14. Some flakiness? Trying to solve using the redis xdist

    @euri10
    euri10 committed Feb 14, 2024
    Configuration menu
    Copy the full SHA
    ba6fcc2 View commit details
    Browse the repository at this point in the history

Commits on Feb 15, 2024

  1. Cleant the redis_client fixture making it flushall each time, and abo… 

    …ve all removing the Redis sync instance created there that was never closed
    @euri10
    euri10 committed Feb 15, 2024
    Configuration menu
    Copy the full SHA
    570ac9b View commit details
    Browse the repository at this point in the history

  2. Made the introduced test redis "aware"

    @euri10
    euri10 committed Feb 15, 2024
    Configuration menu
    Copy the full SHA
    e85b428 View commit details
    Browse the repository at this point in the history

  3. Just comment the introduced test to see if fxture change doesn't mess… 

    … with existing suite
    @euri10
    euri10 committed Feb 15, 2024
    Configuration menu
    Copy the full SHA
    7b4741b View commit details
    Browse the repository at this point in the history

  4. Do we need really a test, or should it uses a mock like all times wit… 

    …h_client is used
    @euri10
    euri10 committed Feb 15, 2024
    Configuration menu
    Copy the full SHA
    45ee20e View commit details
    Browse the repository at this point in the history

  5. Do we need really a test, or should it uses a mock like all times wit… 

    …h_client is used
    @euri10
    euri10 committed Feb 15, 2024
    Configuration menu
    Copy the full SHA
    40f2253 View commit details
    Browse the repository at this point in the history

  6. Removed sync redis instance from fixture

    @euri10
    euri10 committed Feb 15, 2024
    Configuration menu
    Copy the full SHA
    f7ae116 View commit details
    Browse the repository at this point in the history

Commits on Feb 22, 2024

  1. You cannot yield the redis client weirdly enough...

    @euri10
    euri10 committed Feb 22, 2024
    Configuration menu
    Copy the full SHA
    e2bc0c8 View commit details
    Browse the repository at this point in the history

  2. Use async context manager in docker stuff as well

    @euri10
    euri10 committed Feb 22, 2024
    Configuration menu
    Copy the full SHA
    58272d4 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'redis_test_cleaning' into 3083 

    # Conflicts:
#	tests/conftest.py
    @euri10
    euri10 committed Feb 22, 2024
    Configuration menu
    Copy the full SHA
    dc1f3ca View commit details
    Browse the repository at this point in the history

Commits on Feb 25, 2024

  1. We need to explicitely pass this otherwise using with_namespace after… 

    … with_client will lose the automatic handling
    @euri10
    euri10 committed Feb 25, 2024
    Configuration menu
    Copy the full SHA
    3fc2cf2 View commit details
    Browse the repository at this point in the history

Commits on Feb 26, 2024

  1. Let's keep the fixtures as-is

    @euri10
    euri10 committed Feb 26, 2024
    Configuration menu
    Copy the full SHA
    99a814d View commit details
    Browse the repository at this point in the history

  2. Add a test for with_client _shutdown

    @euri10
    euri10 committed Feb 26, 2024
    Configuration menu
    Copy the full SHA
    fd2b54b View commit details
    Browse the repository at this point in the history

  3. Remove the redis_service fixture from the test, note that it won't ru… 

    …n on its own now but most likely will please the CI
    @euri10
    euri10 committed Feb 26, 2024
    Configuration menu
    Copy the full SHA
    3651fe5 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'main' into 3083

    @euri10
    euri10 authored Feb 26, 2024
    Configuration menu
    Copy the full SHA
    5e0f521 View commit details
    Browse the repository at this point in the history

  5. Update litestar/stores/redis.py 

    Co-authored-by: Janek Nouvertné <provinzkraut@posteo.de>
    @euri10 @provinzkraut
    euri10 and provinzkraut authored Feb 26, 2024
    Configuration menu
    Copy the full SHA
    2c91e09 View commit details
    Browse the repository at this point in the history

Commits on Feb 27, 2024

  1. Merge branch 'main' into 3083

    @euri10
    euri10 authored Feb 27, 2024
    Configuration menu
    Copy the full SHA
    aac3fb5 View commit details
    Browse the repository at this point in the history