Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Fix minor issues in docs/usage/applications.rst #3114

Merged

Conversation

aranvir
Copy link
Contributor

@aranvir aranvir commented Feb 14, 2024

Description

Suggestions for better alignment between descriptions and code examples. Also attempted to fix stale link (but not used to rst, so not sure if that works like that).

Closes

Closes #3110
Closes #2688

@aranvir aranvir requested review from a team as code owners February 14, 2024 19:12
@provinzkraut provinzkraut changed the title Fixing minor issues in docs/usage/applications.rst doc: Fix minor issues in docs/usage/applications.rst Feb 14, 2024
@provinzkraut provinzkraut changed the title doc: Fix minor issues in docs/usage/applications.rst docs: Fix minor issues in docs/usage/applications.rst Feb 14, 2024
docs/usage/applications.rst Outdated Show resolved Hide resolved
@provinzkraut
Copy link
Member

Thanks @aranvir! I've left a small correction, apart from that it looks good!

Copy link
Member

@JacobCoffee JacobCoffee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, couple of nits but no big deal

docs/usage/applications.rst Outdated Show resolved Hide resolved
docs/usage/applications.rst Outdated Show resolved Hide resolved
@provinzkraut provinzkraut force-pushed the docs/applications-fix-inconsistencies branch from 10ce3cb to 50089a3 Compare February 16, 2024 10:15
Copy link

Documentation preview will be available shortly at https://litestar-org.github.io/litestar-docs-preview/3114

@provinzkraut provinzkraut merged commit d109098 into litestar-org:main Feb 16, 2024
20 checks passed
@provinzkraut
Copy link
Member

@all-contributors add @aranvir for docs

Copy link
Contributor

@provinzkraut

I've put up a pull request to add @aranvir! 🎉

robswc pushed a commit to robswc/litestar that referenced this pull request Mar 17, 2024
)

* correcting inconsistencies between description and code example, replacing broken reference


---------

Co-authored-by: Janek Nouvertné <provinzkraut@posteo.de>
Co-authored-by: Jacob Coffee <jacob@z7x.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants