test: closing redis ressources #3117
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note that close_connection_pool is required
…manually or not Co-authored-by: Janek Nouvertné <provinzkraut@posteo.de>
Co-authored-by: Janek Nouvertné <provinzkraut@posteo.de>
…ation decides to handle to close or not
…sn't recognized, we use types-redis
Added some small notes on the test since its setup is rather cumbersome
…ve all removing the Redis sync instance created there that was never closed
… with existing suite
# Conflicts: # tests/conftest.py
… with_client will lose the automatic handling
…n on its own now but most likely will please the CI
Co-authored-by: Janek Nouvertné <provinzkraut@posteo.de>
|
Documentation preview will be available shortly at https://litestar-org.github.io/litestar-docs-preview/3117 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR aims at closing redis ressources properly, the previous fixture uses a sync and an async redis client, the sync one is never closed.
Note that weirdly enough you cant yield the redis_client fixture, I dont get why and it took me while to realize it, if someone can explain I'm all ears.
Closes
nothing, though I think it should help flaky redis test imho