Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Fix typos in the tutorial and contribution guide #3141

Merged
merged 5 commits into from
Feb 26, 2024
Merged

docs: Fix typos in the tutorial and contribution guide #3141

merged 5 commits into from
Feb 26, 2024

Conversation

hugovk
Copy link
Contributor

@hugovk hugovk commented Feb 26, 2024 •
edited
Loading

Description

Tutorial:

  • Use lowercase after colon or semicolon
  • Consistently link to True object
  • TODO-list -> TODO list
  • TODO-item -> TODO item

Contribution Guide:

  • Fix typos
  • Use lowercase after semicolon
  • Update PEP link
  • Update Furo to PyData Sphinx Theme

@hugovk hugovk requested review from a team as code owners February 26, 2024 15:37
@hugovk hugovk changed the title Fix typos in the tutorial and contribution guide docs: Fix typos in the tutorial and contribution guide Feb 26, 2024
@cofin
Copy link
Member

cofin commented Feb 26, 2024

@all-contributors please add @hugovk for docs

@allcontributors allcontributors bot mentioned this pull request Feb 26, 2024
Merged
@allcontributors AllContributors
Copy link
Contributor

@cofin

I've put up a pull request to add @hugovk! 🎉

JacobCoffee
JacobCoffee approved these changes Feb 26, 2024
View reviewed changes
Copy link
Member

@JacobCoffee JacobCoffee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice to see you here :D

Thanks!

@JacobCoffee
Copy link
Member

@all-contributors add @hugovk docs

@allcontributors AllContributors
Copy link
Contributor

@JacobCoffee

@hugovk already contributed before to doc

@JacobCoffee
Copy link
Member

wow beat me @cofin

@JacobCoffee JacobCoffee enabled auto-merge (squash) February 26, 2024 15:43
auto-merge was automatically disabled February 26, 2024 15:45

Head branch was pushed to by a user without write access

@codecov Codecov
Copy link

codecov bot commented Feb 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.27%. Comparing base (7646396) to head (20bb534).

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #3141   +/-   ##
=======================================
  Coverage   98.26%   98.27%           
=======================================
  Files         320      320           
  Lines       14401    14401           
  Branches     2316     2316           
=======================================
+ Hits        14151    14152    +1     
  Misses        109      109           
+ Partials      141      140    -1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions GitHub Actions
Copy link

Documentation preview will be available shortly at https://litestar-org.github.io/litestar-docs-preview/3141

@provinzkraut provinzkraut merged commit 88f82c5 into litestar-org:main Feb 26, 2024
20 checks passed
robswc pushed a commit to robswc/litestar that referenced this pull request Mar 17, 2024
@hugovk @robswc
docs: Fix typos in the tutorial and contribution guide (litestar-org#…
89308b9 
…3141)

* Fix typo: lowercase after colon or semicolon

* Consistently link to True object

* TODO-list -> TODO list

* TODO-item -> TODO item

* Contribution Guide: fix typos and update links
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JacobCoffee JacobCoffee JacobCoffee approved these changes

@cofin cofin cofin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hugovk @cofin @JacobCoffee @provinzkraut