Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFC] sipeed_tang_mega_138k: new board #523

Merged
merged 1 commit into from
Sep 26, 2023

Conversation

Icenowy
Copy link
Contributor

@Icenowy Icenowy commented Aug 15, 2023

Tagged RFC now because the board (and even the chip on my board) is still at ES stage.

Signed-off-by: Icenowy Zheng <uwu@icenowy.me>
Comment on lines +30 to +35
("led_n", 0, Pins("J14"), IOStandard("LVCMOS33")),
("led_n", 1, Pins("R26"), IOStandard("LVCMOS33")),
("led_n", 2, Pins("L20"), IOStandard("LVCMOS33")),
("led_n", 3, Pins("M25"), IOStandard("LVCMOS33")),
("led_n", 4, Pins("N21"), IOStandard("LVCMOS33")),
("led_n", 5, Pins("N23"), IOStandard("LVCMOS33")),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/search?q=repo%3Alitex-hub%2Flitex-boards+user_led&type=code
https://github.com/search?q=repo%3Alitex-hub%2Flitex-boards+led_n&type=code

Through the repo, there are various naming conventions, and led_n seems one of them.

Curious about what this is meant to be.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

49ffc94

@xobs seems to go towards withdrawing the _n prefix.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well at least I use _n to mean it's active low.

Copy link
Contributor

@josuah josuah Sep 6, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well at least I use _n to mean it's active low.

This makes more sense to me that way too. Thank you for clarifying!

What a carefully crafted board support file! Instructive for myself...

@enjoy-digital enjoy-digital marked this pull request as ready for review September 26, 2023 17:11
@enjoy-digital
Copy link
Member

@Icenowy: We can probably merge now that the board seems to be available. Thanks a lot!

@enjoy-digital enjoy-digital merged commit 29018a8 into litex-hub:master Sep 26, 2023
1 check failed
@Icenowy
Copy link
Contributor Author

Icenowy commented Sep 29, 2023

Well this PR targets ES board with ES chip. Maybe further change will be needed for final product board, I wonder whether Sipeed people want to do this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants