Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add normalized and normalized-fold varieties of match/find/rank #16

Merged
merged 2 commits into from
Dec 9, 2019

Conversation

acaloiaro
Copy link
Contributor

Add Unicode-normalized varieties of all existing functions.

Unicode normalization approach inspired by https://blog.golang.org/normalization

@lithammer
Copy link
Owner

I will take a look at why Travis CI is failing. Or actually, I will probably just switch to GitHub Actions.

@lithammer
Copy link
Owner

I just merged #17 which switches to GitHub Actions for pull requests checks. Can you rebase to see if that solves the pull request check problem?

@acaloiaro acaloiaro force-pushed the add-unicode-normalization branch from f5c1d5d to 2823642 Compare December 9, 2019 13:49
@acaloiaro acaloiaro closed this Dec 9, 2019
@acaloiaro acaloiaro reopened this Dec 9, 2019
@acaloiaro
Copy link
Contributor Author

@lithammer FYI I added a pull_request event to the github action so that checks run on pull requests from forks, as well as on merge. Looks like all tests are passing 🎉

@lithammer
Copy link
Owner

Everything looks in order. Thanks for contributing, this is definitely a nice thing! 👌

@lithammer lithammer merged commit 3120a96 into lithammer:master Dec 9, 2019
@lithammer
Copy link
Owner

I published a new v1.1.0 release that contains this.

@acaloiaro
Copy link
Contributor Author

@lithammer happy to contribute and thanks for the quick turnaround. Cheers!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants