Fix UUID length overflow #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Decode method of DefaultEncoder (base57) doesn't return an error when given a shortuuid string that internally converts to a number longer than 32 hex digits (UUIDs max length), outstanding digits in the returned UUID are simply truncated. Then if such UUID is encoded back to shortuuid its value is different from the initial shortuuid.
shortuuids which overflow UUIDs max length should be recognized by the library as invalid and a corresponding error should be returned.
I implemented this in my pull request, and added a test for decoding errors.