Quick & Dirty update to support upstream changes. #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! Just had a quick look at the upstream changes. And from the looks of things you could probably simplify this a bit by using the I think this is good enough for now since it fixes master while still maintaining backwards compatibility. But should probably consider changing the function return signature to |
|
Good catch! I was in a bit of a rush and didn't investigate too much. I've updated it to use the |
|
I released a new version (v2.0.1) too in case you're using that. I will probably hold off a bit on changing the return values until satori/go.uuid#66 has been resolved (be it closed or reverted). |
Closed
lithammer
pushed a commit
that referenced
this pull request
Feb 14, 2018
Given the recent issues with github.com/satori/go.uuid (satori/go.uuid#66), which are still partly unresolved, e.g. its master isn't compatible with us (see #7, #8, #9, 10, #11 and #12). Even though github.com/google/uuid is only at v0.1 and clearly states this: >This package is currently in development and the API may not be stable. > >The API will become stable with v1. I suspect it's a better longterm investment.
lithammer
pushed a commit
that referenced
this pull request
Feb 14, 2018
Given the recent issues with github.com/satori/go.uuid (satori/go.uuid#66), which are still partly unresolved, e.g. its master isn't compatible with us (see #7, #8, #9, 10, #11 and #12). Even though github.com/google/uuid is only at v0.1 and clearly states this: >This package is currently in development and the API may not be stable. > >The API will become stable with v1. I suspect it's a better longterm investment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The upstream UUID package has changed the definition of
NewV4and as a result this package has broken.I am not in love with this proposal, but it at least takes care of the immediate problem. I think ideally the methods should be updated to reflect the new multi-value returns seen upstream, but I did not want to destabilize head without discussion.