Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add codes for Daikin FWT-GT on ESPHome #101

Merged
merged 3 commits into from
Aug 13, 2024

Conversation

ripa1993
Copy link

@ripa1993 ripa1993 commented Aug 5, 2024

Add codes for Daikin FWT-GT on ESPHome

@ripa1993 ripa1993 marked this pull request as ready for review August 5, 2024 17:06
@litinoveweedle
Copy link
Owner

Hello, thank you for PR, please remove any modifications to the DOCS pages, as those are generated automatically. (docs/CLIMATE_CODES.md)

@litinoveweedle
Copy link
Owner

thanks. In addition you have error in the json:

Invalid climate device JSON file '7100.json': missing or invalid attribute 'temperatureUnit'.

Please check docs if you need to know more about this param.

@litinoveweedle
Copy link
Owner

Hello, lint run just discovered new issue:

Invalid climate device JSON file '7100.json': operation mode 'on_once' is not defined, but it is used in commands.

Is this something your setup requires?

@ripa1993
Copy link
Author

ripa1993 commented Aug 9, 2024

@litinoveweedle should be fine now, I renamed on_once to on and on == off.

This device has a single command for both on/off and the status is maintained by the AC unit. If I got it right from climate.py if the state is not off, then it should not send the on command again, right?

Sorry but I blindly copy pasted the device codes from the original repo

@litinoveweedle
Copy link
Owner

Hello, no problem.

Yes, your understanding is fully correct, I made this change from the original implementation to exactly solve this issue based on some users experience when on == off commands. So you shall be fully fine (at least with beta, which would be hopefully released soon).

@litinoveweedle litinoveweedle merged commit ad7f1e7 into litinoveweedle:master Aug 13, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants