Make HACS show details/readme on SmartIR landing page #140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@icefest I just released 1.19.0b1 with the changes, but in my HA I still do not see the readme generated. I did even added render_readme (even if deprecated to hacs.json), but without success. How does it look in your HA? |
|
Your repository still isn't loading the readme. On the other hand https://github.com/icefest/SmartIR loads it fine if you add it as a custom repository, and github says that's identical to yours! |
|
I know, I discovered the same. But I have no idea why. It seems to be HACS issue. From time of the HACS 2.0 I am having all kind of issues with the it. So no idea here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HACS doesn't show details on SmartIR landing page.
I'm fairly sure that HACS will only display the README.md as the display file, and only if the json file is also updated.
I've renamed info.md to README.md, to allow HACS to display it,
I've edited hacs.json to tell HACS to display it.
see issue #136, with screenshot of results from this edit.
see discussion on #138, where I couldn't figure out why it didn't work.