Update fan.py #26
Merged
Update fan.py #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix warning:- SUPPORT_SET_SPEED was used from smartir, this is a deprecated constant.. Use FanEntityFeature.SET_SPEED instead.. SUPPORT_DIRECTION was used from smartir, this is a deprecated constant.. Use FanEntityFeature.DIRECTION instead.. SUPPORT_OSCILLATE was used from smartir, this is a deprecated constant.. Use FanEntityFeature.OSCILLATE instead..
|
Hello, I would prefer to replace old constant names by the new enum FanEntityFeature in the whole code. May I ask you to refactor the PR? Or I can prepare PR myself, I would keep you as contributor in any case. ;-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix warning:-
SUPPORT_SET_SPEED was used from smartir, this is a deprecated constant.. Use FanEntityFeature.SET_SPEED instead..
SUPPORT_DIRECTION was used from smartir, this is a deprecated constant.. Use FanEntityFeature.DIRECTION instead..
SUPPORT_OSCILLATE was used from smartir, this is a deprecated constant.. Use FanEntityFeature.OSCILLATE instead..