Use inspect.iscoroutinefunction instead of asyncio.iscoroutinefunction to avoid Python 3.14 deprecation warning
#220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edgarrmondragon
force-pushed
the
use-inspect.iscoroutinefunction
branch
from
01d3e70
to
401709d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The function
asyncio.iscoroutinefunctionwas recently deprecated in Python 3.14.0a1 and will be removed in Python 3.16: https://docs.python.org/3.14/whatsnew/3.14.html#deprecated.The function's had a consistent implementation at least since Python 3.7:
Which means it's safe to use
inspect.iscoroutinefunctionin this package without checking the Python version.FWIW the deprecation first appears in:
https://github.com/python/cpython/blob/v3.14.0a1/Lib/asyncio/coroutines.py#L20-L27