-
Notifications
You must be signed in to change notification settings - Fork 700
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Pre Commit Check #4642
Merged
Saranya-jena
merged 8 commits into
litmuschaos:master
from
Wise-Wizard:Feature/Pre_Commit
Nov 22, 2024
Merged
Add Pre Commit Check #4642
Saranya-jena
merged 8 commits into
litmuschaos:master
from
Wise-Wizard:Feature/Pre_Commit
Nov 22, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Wise-Wizard <saransh.shankar@gmail.com>
Signed-off-by: Wise-Wizard <saransh.shankar@gmail.com>
Signed-off-by: Wise-Wizard <saransh.shankar@gmail.com>
Hi, are there any changes that needs to be done? |
SahilKr24
approved these changes
Sep 6, 2024
namkyu1999
added
the
need-approvers-review
Reminder label to the codeowners/maintainers for stale PRs that are more that 2 weeks old
label
Nov 15, 2024
S-ayanide
approved these changes
Nov 22, 2024
Saranya-jena
approved these changes
Nov 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
need-approvers-review
Reminder label to the codeowners/maintainers for stale PRs that are more that 2 weeks old
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
I implemented a feature to remove unused strings from the pre-commit script. This enhancement addresses the issue reported in litmuschaos/litmus#4550 by ensuring that only necessary strings are retained in the
strings.en.yaml
file.Types of changes
What types of changes does your code introduce to Litmus? Put an
x
in the boxes that applyChecklist
Put an
x
in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.Dependency
Special notes for your reviewer: