Contextually set a Source.probe's FFprobe input type based upon URI #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…th, rather than a ReadableStream
jwerle
requested changes
Feb 24, 2020
source.js
Outdated
| const { uri } = this | ||
| const stream = this.createReadStream(opts) | ||
| const stream = this.uri.includes('file://') ? |
There was a problem hiding this comment.
Could we have a null check for this.uri in case it isn't available and only a stream can be created?
There was a problem hiding this comment.
Fo' sho - a92388d
jwerle
requested changes
Feb 24, 2020
source.js
Outdated
| @@ -223,7 +223,7 @@ class Source extends Resource { | |||
|
|
|||
|
|
|||
| const { uri } = this | |||
| const stream = this.uri.includes('file://') ? | |||
| const stream = this.uri !== undefined && this.uri.includes('file://') ? | |||
There was a problem hiding this comment.
Can you check for null instead? or just a truthy check
jwerle
approved these changes
Feb 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces code in
Source.probe, which sets the FFprobe input as a file path string when the Source.uri begins withfile://, and for all other types of URIs, sets the input as a ReadableStream.Address the concerns raised in #13 - mainly, that sending Sources with a file:// URI degrades the potential data quality FFprobe can return when probing for container-level metadata.