This repository has been archived by the owner on Oct 26, 2022. It is now read-only.
Various netlink-proto Encoder impl fixes #168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fe8cb5e introduced this when to_bytes() didn't return the size anymore.
- don't allocate in 2048 steps; we know the total size of additional space required (added in d1deb12) - BytesMut can expand to usize::MAX now; so checking remaining_mut() only prevents a size overflow (can't allocate it anyway). - BytesMut::resize actually changes the size of the buffer and reduces `remaining_mut` - need to actually reserve enough space before taking `&mut buf.chunk_mut()[..msg_len];`
The only semantic difference: on unwind (panic in serialize) the buffer length already is the new one (but the contents were initialized to 0 anyway).
|
The missing netlink/netlink-proto/src/framed.rs Line 145 in 32c1f98 BytesMut::chunk_mut() allocates if capacity is reached). Without manipulating INITIAL_WRITER_CAPACITY one might have to send a message > 8k to trigger it.
|
JohnTitor
approved these changes
Jun 6, 2021
little-dude
pushed a commit
that referenced
this pull request
Nov 22, 2021
Various netlink-proto Encoder impl fixes
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Afaict the missing
reservebefore line 175 might actually cause panics when serializing messages that need more space than the current buffercapacityprovides.Hitting
buf.remaining_mut() < msg_lenis quite unlikely, but would probably end in OOM (and loop until it does).