This repository has been archived by the owner on Oct 26, 2022. It is now read-only.
LinkAddRequest: Allow adding macvlan on a specified link.
#194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@cathay4t @little-dude Could you PTAL |
|
Let me know if any custom configuration is needed for payload. However this should be good for start ? Ackd: for CI let me push formatted version. |
flouthoc
force-pushed
the
add_request_macvlan
branch
from
0ffba3e to
8573e62
Compare
|
It seems CI is asking me to |
flouthoc
force-pushed
the
add_request_macvlan
branch
2 times, most recently
from
dc55251 to
7af2e95
Compare
|
@cathay4t @little-dude Could we re-trigger CI again plz. |
Following adds support to create MACVLAN on a link. This is equivalent to `ip link add NAME name link LINK type macvlan mode MACVLAN_MODE`. But instead of specifying a link name (LINK), we specify a link index and a mode. Veth must be already up for this to work. Following behaviour is expected cause its same for `vxlan` and `vlan`. Signed-off-by: Aditya Rajan <arajan@redhat.com>
flouthoc
force-pushed
the
add_request_macvlan
branch
from
7af2e95 to
eb1c8c5
Compare
|
Patch looks good to me. Manual tested with example code, works well. |
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Team,
Thank you so much for porting and maintaining
netlinkbindings.Following PR adds support to create MACVLAN on a link.
This is equivalent to
ip link add NAME name link LINK type macvlan mode MACVLAN_MODE.But instead of specifying a link name (LINK), we specify a link index
and a mode.
Veth must be already up for this to work. Following behaviour is
expected cause its same for
vxlanandvlan.Thanks again.