This repository has been archived by the owner on Oct 26, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 89
Refactor base types #195
Merged
little-dude
merged 11 commits into
little-dude:master
from
stbuehler:refactor-base-types
Nov 17, 2021
Merged
Refactor base types #195
little-dude
merged 11 commits into
little-dude:master
from
stbuehler:refactor-base-types
Nov 17, 2021
Commits on Nov 14, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 66c270b - Browse repository at this point
Copy the full SHA 66c270bView commit details -
Configuration menu - View commit details
-
Copy full SHA for dfb55f5 - Browse repository at this point
Copy the full SHA dfb55f5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1cd3e0f - Browse repository at this point
Copy the full SHA 1cd3e0fView commit details -
Remove
T
generic from NetlinkDeserializable and NetlinkSerializable`T` always was the same as `Self`. Also do a major bump on depending crates.
Configuration menu - View commit details
-
Copy full SHA for 94c2632 - Browse repository at this point
Copy the full SHA 94c2632View commit details -
Remove constraints from type definitions; remove unneeded constraints…
… in implementations (apart from Debug) - where clauses are almost never needed on type definitions unless you need them in the `Drop` implementation - Debug trait might be useful if (debug) logging gets added - Clone/PartialEq/Eq shouldn't be needed ever in the implementations
Configuration menu - View commit details
-
Copy full SHA for 71b71ce - Browse repository at this point
Copy the full SHA 71b71ceView commit details
Commits on Nov 15, 2021
-
Make codec a Connection type parameter, split audit implementation
1. get rid of "workaround-audit-bug" "feature" 2. no longer use tokio_util::codec::{Decoder, Encoder} tokio_util::codec is "designed" for bytestreams (and building "frames" of messages on top), but we need to deal with datagrams (which still can contain multiples messages, just not one message across multiple datagrams). This make it a little less "combinable", but we actually don't want people to reuse these codecs on bytestream (and writing an adapter wouldn't be that hard anyway). Also we can use a fixed error type, making dealing with it a little bit easier.
Configuration menu - View commit details
-
Copy full SHA for cac815a - Browse repository at this point
Copy the full SHA cac815aView commit details -
Configuration menu - View commit details
-
Copy full SHA for eda4596 - Browse repository at this point
Copy the full SHA eda4596View commit details -
Fix UB from unsafe uninitialized buffer slices
Creating &mut [u8] (and &[u8]) for unitialized memory is undefined behaviour even when not actually reading the data. Use bytes::BufMut instead, and advance buffer in recv functions. High level functions (without flags param) don't need to return length of read, as it was used to advance the buffer - only low-level read might return larger length than the buffer (PEEK + TRUNC flags). This also bumps netlink-sys; the other crates already got bumped.
Configuration menu - View commit details
-
Copy full SHA for 7e6cfd7 - Browse repository at this point
Copy the full SHA 7e6cfd7View commit details -
Add AsyncSocket trait in netlink-sys
Preparation to make tokio and smol feature non-conflicting in netlink-proto.
Configuration menu - View commit details
-
Copy full SHA for 1ea0da5 - Browse repository at this point
Copy the full SHA 1ea0da5View commit details -
Make tokio and smol not conflicting in netlink-proto
- This adds a new type paramater to connection for the socket being used. - can drop tokio/smol selection from netlink-packet-audit
Configuration menu - View commit details
-
Copy full SHA for 944307c - Browse repository at this point
Copy the full SHA 944307cView commit details -
Configuration menu - View commit details
-
Copy full SHA for aa89fe6 - Browse repository at this point
Copy the full SHA aa89fe6View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.