This repository has been archived by the owner on Oct 26, 2022. It is now read-only.
rtnetlink: add replace option to Add*Request #202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
little-dude
reviewed
Nov 25, 2021
Tuetuopay
force-pushed
the
rtnl-nlm-f-replace
branch
from
0fd039a to
e4b41a6
Compare
little-dude
approved these changes
Nov 25, 2021
There was a problem hiding this comment.
Thanks, this is great 👍
Just like #203 I'm going to wait for a day before merging in case someone else wants to review this.
Tuetuopay
force-pushed
the
rtnl-nlm-f-replace
branch
from
e4b41a6 to
7b34d8f
Compare
This option sets the NLM_F_REPLACE instead of the NLM_F_EXCL flag, allowing "create or update" patterns.
little-dude
added a commit
that referenced
this pull request
Nov 28, 2021
although #203 and #202 had no direct conflict, merging both broke rtnetlink: ``` error[E0063]: missing field `replace` in initializer of `neighbour::add::NeighbourAddRequest` --> rtnetlink/src/neighbour/add.rs:58:9 | 58 | NeighbourAddRequest { handle, message } | ^^^^^^^^^^^^^^^^^^^ missing `replace` ```
Merged
mcginty
pushed a commit
to mcginty/netlink
that referenced
this pull request
Jan 18, 2022
although little-dude#203 and little-dude#202 had no direct conflict, merging both broke rtnetlink: ``` error[E0063]: missing field `replace` in initializer of `neighbour::add::NeighbourAddRequest` --> rtnetlink/src/neighbour/add.rs:58:9 | 58 | NeighbourAddRequest { handle, message } | ^^^^^^^^^^^^^^^^^^^ missing `replace` ```
cathay4t
pushed a commit
to rust-netlink/rtnetlink
that referenced
this pull request
Oct 7, 2022
although little-dude/netlink#203 and little-dude/netlink#202 had no direct conflict, merging both broke rtnetlink: ``` error[E0063]: missing field `replace` in initializer of `neighbour::add::NeighbourAddRequest` --> rtnetlink/src/neighbour/add.rs:58:9 | 58 | NeighbourAddRequest { handle, message } | ^^^^^^^^^^^^^^^^^^^ missing `replace` ```
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This option sets the
NLM_F_REPLACEinstead of theNLM_F_EXCLflag, allowing "create or update" patterns.My current usecase is for managing neighbors, for which I have a control plane, but it can happen that the neighbor is learnt from the dataplane first, and controlplane second. In this case, I want to set the neighbor as
NOARPto prevent it from expiring. The easiest is to allow the kernel to just replace the neighbor with the one provided rather than create-fail-delete-create.