Skip to content
This repository has been archived by the owner on Oct 26, 2022. It is now read-only.

use latest netlink-packet-generic as dependency in other subcrates #223

Merged
merged 2 commits into from
Jan 11, 2022

Conversation

mcginty
Copy link
Contributor

@mcginty mcginty commented Jan 5, 2022

Otherwise a crate already depending on netlink-packet-generic 0.3 will get errors like this when compiling:

 the trait `netlink_packet_generic::traits::GenlFamily` is not implemented for `Wireguard`

@mcginty mcginty changed the title netlink-packet-wireguard: use latest netlink-packet-generic as dependency use latest netlink-packet-generic as dependency in other subcrates Jan 5, 2022
Copy link
Owner

@little-dude little-dude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry about this. I'm traveling today so I can only make a release tonight (CET).

@mcginty
Copy link
Contributor Author

mcginty commented Jan 5, 2022

No rush! Thanks for taking a look (and for the latest release with wireguard support!).

Copy link
Collaborator

@cathay4t cathay4t left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cathay4t cathay4t merged commit 4889ef8 into little-dude:master Jan 11, 2022
@little-dude
Copy link
Owner

Hey @mcginty

Sorry for not coming back to this, I've had covid since last Friday. Will make a release in a couple days when I feel better.

@mcginty
Copy link
Contributor Author

mcginty commented Jan 12, 2022

I hope the symptoms weren't too bad @little-dude, take your time recovering, open source necessarily is slightly less important than staying alive and healthy ;). I just got it as well a few weeks ago...

I'm not blocked on a release or anything right now since I can depend on my fork's branch in the meanwhile!

@little-dude
Copy link
Owner

@mcginty I just made a new release! Let me know if you have further issues with these crates, I don't use them myself. https://github.com/little-dude/netlink/releases/tag/20220115

cathay4t pushed a commit to rust-netlink/ethtool that referenced this pull request Oct 7, 2022
cathay4t pushed a commit to rust-netlink/genetlink that referenced this pull request Oct 7, 2022
cathay4t pushed a commit to rust-netlink/netlink-packet-wireguard that referenced this pull request Oct 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants