This repository has been archived by the owner on Oct 26, 2022. It is now read-only.
utils: Optimized calculation align #229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wllenyj
force-pushed
the
round_up
branch
2 times, most recently
from
c155356
to
cf98060
Compare
|
@little-dude Have some comments for the pr? |
little-dude
suggested changes
Feb 12, 2022
There was a problem hiding this comment.
Thanks for this improvement and for adding tests :) This looks great, but could we just rename RTA into NLA for consistency? I know in the kernel it's called RTA and perhaps it was the wrong decision to diverge from that in the first place, but now that we went for NLA, I'd rather stay consistent.
Use bitwise operations instead of division. The length value must be less than `usize::MAX - 4`, otherwise it will panic. The result is the same as the original logic. Signed-off-by: wllenyj <wllenyj@linux.alibaba.com>
Sure, fixed. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use bitwise operations instead of division.
The length value must be less than
usize::MAX - 4, otherwise it willpanic. The result is the same as the original logic.
Signed-off-by: wllenyj wllenyj@linux.alibaba.com