Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NEW add paths and if statements for SS_DUMP_FILES #141

Merged
merged 5 commits into from
Jan 22, 2022
Merged

NEW add paths and if statements for SS_DUMP_FILES #141

merged 5 commits into from
Jan 22, 2022

Conversation

backamblock
Copy link
Contributor

Now ;)

@backamblock
Copy link
Contributor Author

hm, i didn't want to add the gitignore file. but i don't know how to exclude it ... sorry

@jessuppi
Copy link
Member

So apparently GitHub decided to remove cherry picking from the UI... bummer for those like me who use the UI.

Ref: https://git.luolix.topmunity/t/feature-request-cherry-pick-commits-from-ui/1842/6
Ref: isaacs/github#629

@jessuppi jessuppi merged commit a60cba7 into littlebizzy:master Jan 22, 2022
@jessuppi
Copy link
Member

By the way, in the future we should probably consider putting the "skip rules" for FastCGI cache in a separate Nginx module to keep it cleaner so that users only install the module for their own language.

e.g. /etc/nginx/conf.d/skip-cache.conf or something

@jessuppi jessuppi mentioned this pull request Jan 22, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jessuppi jessuppi jessuppi approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@backamblock @jessuppi