Change assert to runtime check. #359
Conversation
I had a system that was constantly hitting this assert, after making this change it recovered immediately.
geky
added
needs minor version
|
Hi @cdesjardins, thanks for creating a PR! I'm of the opinion this check should actually be done when we first find the bad block addresses (so in lfs_file_open, lfs_dir_open, lfs_stat, or similar). I want to see if that can accomplished before the next release, if not I'll going ahead merge this in. |
geky
removed
the
needs minor version
|
Ok! I've merged this into #372 and added tests and a couple of other checks. I looked into different implementations of this check, but now think your original proposal is the best solution. Thanks again for the PR. I will close this when #372 is merged. I don't think GitHub is smart enough to track cherry-picks across PRs. |
|
Closing as this has been merged into #372, unfortunately I don't think I merged it in a way that is reflected here in GitHub. |
|
Thanks for the contribution! |
I had a system that was constantly hitting this assert, after making
this change it recovered immediately.