-
Notifications
You must be signed in to change notification settings - Fork 254
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
improve fzf #282
improve fzf #282
Conversation
layers/+tools/fzf/config.vim
Outdated
command! Sessions call s:sessions() | ||
nnoremap <silent> <leader>sf :Sessions<cr> | ||
|
||
let g:fzf_colors = |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
g:fzf_colors
has been already configured, see
space-vim/layers/+tools/fzf/config.vim
Line 13 in 3bbf9f5
let g:fzf_colors = g:spacevim#plug#fzf#colors |
layers/+tools/fzf/config.vim
Outdated
\}) | ||
endfunction | ||
command! Sessions call s:sessions() | ||
nnoremap <silent> <leader>sf :Sessions<cr> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Move this block, s:sessions()
, to core/autoload/spacevim/plug/fzf.vim
, i.e., spacevim#plug#fzf#Session()
.
nnoremap <silent> <Leader>fs :call spacevim#plug#fzf#Session()<CR>
What's more, no need to define Sessions
command.
Last but not the least, please split this single PR into 2. One PR for tmux specific and the other for fzf related. |
it seems like that "leader fs " has been mapped. |
core/autoload/spacevim/plug/fzf.vim
Outdated
\ call fzf#vim#files(<q-args>, fzf#vim#with_preview(), <bang>0) | ||
" } | ||
|
||
function! s:spacevim#plug#fzf#Session() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove s:
, s:spacevim#plug#fzf#Session()
-> spacevim#plug#fzf#Session()
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sorry
core/autoload/spacevim/plug/fzf.vim
Outdated
@@ -190,6 +190,34 @@ function! s:align_lists(lists) | |||
return a:lists | |||
endfunction | |||
|
|||
autocmd VimEnter * command! -bang -nargs=* Ag |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
autocmd VimEnter *
is useless in the autoload
mechanism. So, remove autocmd VimEnter *
.
To be honest,use the custom fzf colors maybe more reasonable,as follow, |
Yeah, space-vim only guarantee the default space-vim/core/autoload/spacevim/plug/fzf.vim Lines 1 to 15 in b9786fb
User can override g:fzf_colors in UserConfig if it looks strange.
|
Ok,it's uncontroversial any more. |
Merged, thanks! |
* improve fzf and fix ctrl arrows conflix in tmux * improve fzf * improve fzf * improve fzf
No description provided.