Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider using new matchfuzzy() built in function #535

Closed
craigmac opened this issue Oct 3, 2020 · 4 comments · Fixed by #607
Closed

Consider using new matchfuzzy() built in function #535

craigmac opened this issue Oct 3, 2020 · 4 comments · Fixed by #607

Comments

@craigmac
Copy link

craigmac commented Oct 3, 2020

Describe the solution you'd like
Ability to use this plugin using only built in Vim feature for fuzzy matching. A really new fuzzy match function written in C should make it possible to not rely on Rust if user has a Vim version with the correct patch.

Additional context
The PR and function I’m talking about: vim/vim#6932

@issue-label-bot
Copy link

Issue-Label Bot is automatically applying the label feature_request to this issue, with a confidence of 0.93. Please mark this comment with 👍 or 👎 to give our bot feedback!

Links: app homepage, dashboard and code for this bot.

@romgrk
Copy link
Collaborator

romgrk commented Oct 24, 2020

Neovim will probably get it too: neovim/neovim#12995 It might make it more attractive then if both vim & neovim have it.

@liuchengxu
Copy link
Owner

Yeah, this also just needs some glue code similar to #565. But we have to take care of some extra stuffs that the Rust binary maple does:

Not sure matchfuzzy() and fzy-lua already handle these cases.

@liuchengxu
Copy link
Owner

@craigmac Try #607, you can use let g:clap_force_matchfuzzy = 1 to test it. Any suggestions are welcome.

liuchengxu added a commit that referenced this issue Jan 5, 2021
* Add support for matchfuzzy()

Close #535

* Add g:clap_force_matchfuzzy

* Take care of latest result of matchfuzzypos()

* Update CHANGELOG.md

* .
@liuchengxu liuchengxu unpinned this issue Jan 5, 2021
liuchengxu added a commit that referenced this issue Jan 10, 2021
.
Add the providers defined via global variable in `providers` provider (#605)

* Add the providers defined using gloabl variable in providers provider

* Update CHANGELOG.md

* Update README.md

* .

v0.22

Support the builtin matchfuzzy() (#607)

* Add support for matchfuzzy()

Close #535

* Add g:clap_force_matchfuzzy

* Take care of latest result of matchfuzzypos()

* Update CHANGELOG.md

* .

.

Remove line_splitter.rs

.

Rename all to match_type on vim side

.

.

Rename to IgnoreFilePath

.

Rename to MatchResult

Change to SkimMatcherV2

.

Rename to source_item

.
liuchengxu added a commit that referenced this issue Jan 10, 2021
Add the providers defined via global variable in `providers` provider (#605)

* Add the providers defined using gloabl variable in providers provider

* Update CHANGELOG.md

* Update README.md

* .

v0.22

Support the builtin matchfuzzy() (#607)

* Add support for matchfuzzy()

Close #535

* Add g:clap_force_matchfuzzy

* Take care of latest result of matchfuzzypos()

* Update CHANGELOG.md

* .

.

Remove line_splitter.rs

.

Rename all to match_type on vim side

.

.

Rename to IgnoreFilePath

.

Rename to MatchResult

Change to SkimMatcherV2

.

Rename to source_item

.
liuchengxu added a commit that referenced this issue Jan 16, 2021
* Refactor each input line as a SourceItem

Add the providers defined via global variable in `providers` provider (#605)

* Add the providers defined using gloabl variable in providers provider

* Update CHANGELOG.md

* Update README.md

* .

v0.22

Support the builtin matchfuzzy() (#607)

* Add support for matchfuzzy()

Close #535

* Add g:clap_force_matchfuzzy

* Take care of latest result of matchfuzzypos()

* Update CHANGELOG.md

* .

.

Remove line_splitter.rs

.

Rename all to match_type on vim side

.

.

Rename to IgnoreFilePath

.

Rename to MatchResult

Change to SkimMatcherV2

.

Rename to source_item

.

* .

* Fix tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants