Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecation since 3.3 and break at 4.0 #129

Closed
ricohumme opened this issue Dec 29, 2017 · 6 comments
Closed

Deprecation since 3.3 and break at 4.0 #129

ricohumme opened this issue Dec 29, 2017 · 6 comments

Comments

@ricohumme
Copy link

Hi,

Probably already know to you but didn't see it yet in the issues

Autowiring services based on the types they implement is deprecated since Symfony 3.3 and won't be supported in version 4.0. You should rename (or alias) the "phpexcel" service to "Liuggio\ExcelBundle\Factory" instead.
@adiq
Copy link

adiq commented Jan 2, 2018

@ricohumme: the awesome guy @Jan0707 actually fixed this on SymfonyCon Cluj Hackday in ebd0f04 + 598129a

We can just hope that @liuggio will consider moving this commit to master as soon as possible (as there are no BC breaks). A quick fix would be to just define this service and alias yourself, but that's more of a hack then real solution.

@doxt3r
Copy link

doxt3r commented Jan 2, 2018

+1

@Jan0707
Copy link

Jan0707 commented Jan 2, 2018

A quick fix would be to just define this service and alias yourself, but that's more of a hack then real solution.

I support this approach as an intermediate fix

@trogwarz
Copy link

trogwarz commented Feb 9, 2018

@liuggio, any news on this?

@adiq
Copy link

adiq commented Feb 9, 2018

@trogwarz I think this library is not maintained anymore. Consider using new one as mentioned in #125 (comment) ;-)

@ricohumme
Copy link
Author

This is true. Composer shows this bundle has been abandoned. It recommends phpoffice/phpspreadsheet instead

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants