Prepare for symfony 4 #SymfonyConHackday2017 #125
Conversation
Jan0707
changed the title
|
@Jan0707 Please also update the service definition to use the FQCN's. 😁 |
|
@Jan0707 any plans on fixing the mentioned issues in the near future? |
|
Sorry folks, I was travelling. I renamed the service, but added a legacy alias, so that we do not break all the installations out there ;) |
|
Please create a new release when this is fixed @Jan0707. |
|
Not really sure what to do about the memory issue here ... |
|
Hey, I have added some tweaks to this changes: Jan0707#1 This fixes:
Now, it all comes down to what versions of symfony/php would you want to support. From what I discovered symfony versions <3.2 have an issue when running tests due to Maybe some compromise would be just to release v3 version as the users of older symfony versions would not benefit from this changes IMHO and it would be easier to maintain ;-) |
|
Could we at least manage to support 3.4 as LTS ? |
|
That's the question to the maintainer. Newest 3.X version is included in tests and is passing successfully |
Prepare symfony 4 - tweaks
|
@adiq I just merged your pr into my pr. |
|
@liuggio can you please merge this and tag a new release? Or is there any issue with the pr? |
|
Hello people. Can I do something to run travis test again to gain that someone aprove this PR? Cheers. |
|
@mrljaime as PhpExcel lib in this bundle is deprecated and maintainer doesn't want to support this, it's recommended to use https://github.com/roromix/SpreadsheetBundle instead. It's using new, maintained lib, is compatible with newer versions of Symfony and is similar in use to this bundle ;-) |
|
Thank's a lot @adiq I will use it right now. |
|
@liuggio Are you planning on checking out this PR or is it time that we use a different bundle? |
| ``` | ||
|
|
||
| - Create an object from a file: | ||
|
|
||
| ``` php | ||
| $phpExcelObject = $this->get('phpexcel')->createPHPExcelObject('file.xls'); | ||
| $phpExcelObject = $this->get('Liuggio\ExcelBundle\Factoryl')->createPHPExcelObject('file.xls'); |
Minor edits to enable installation with symfony 4