Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update code style to respect the PHP Coding Standards #124

Merged
merged 2 commits into from
Dec 14, 2017
Merged

Update code style to respect the PHP Coding Standards #124

merged 2 commits into from
Dec 14, 2017

Conversation

francoispluchino
Copy link
Collaborator

Q A
Branch? master
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets ~
License MIT
Doc PR ~

This PR update the code style to respect the PHP Coding Standards using the PHP Coding Standards Fixer.

@DonCallisto DonCallisto merged commit f382430 into liuggio:master Dec 14, 2017
@DonCallisto
Copy link
Collaborator

Wonderful: maybe we should hook something to check that cs-standards are respected?

@francoispluchino
Copy link
Collaborator Author

For Git you have this example. But for Github, I don't know.

@francoispluchino
Copy link
Collaborator Author

Last point on the quality, you have the URL of the project which redirects to a fucking website (http :// welcometothebundle.com/speedup-symfony-functional-tests-phpunit) !!! I guess initially this was not the case ;-)

@francoispluchino
Copy link
Collaborator Author

@DonCallisto If you do not see what I am talking about, your website link indicated for this repository (that is http://welcometothebundle.com/speedup-symfony-functional-tests-phpunit) redirects to that:

fastest_fucking_website

I think it's a serious problem, especially for the credibility of this tool!

@DonCallisto
Copy link
Collaborator

@francoispluchino I cannot edit this as I don't have privileges. I've wrote to @liuggio but he didn't reply yet.

BTW I'm waiting for your release note to take next step to 1.6 (I'll not be at home in the week end, so you have up to next Monday).

Thanks!

@DonCallisto
Copy link
Collaborator

@francoispluchino we have fixed all the things, now @liuggio added you as a collaborator (you need to accept his invitation): you can release 1.6 if you want: it's plenty of your contribution so you could proceed independently.
Thanks again.

@francoispluchino
Copy link
Collaborator Author

@DonCallisto The v1.6.0 version is released.

@DonCallisto
Copy link
Collaborator

Thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants