Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for the @group annotation at the class level #141

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

michelv
Copy link

@michelv michelv commented Nov 15, 2019

This change brings support for including/excluding whole test classes with the @group annotation and the <groups> tag in the PHPUnit XML configuration file.

The patch applies cleanly to both master and the tag v1.6.1.

@DonCallisto
Copy link
Collaborator

Hi @michelv thanks for your contribution.
As you correctly stated in #142

The drawback is that if the annotation @group is used only on some of the tests in a testsuite, the testsuite will still be executed entirely.

I think that, as this will be a new "feature", you should try to implement this functionality in its entirety so you should also take into account the @group annotation at test level.

If you try to take a look at this and modify accordingly it would be great.
If you find some issue let me know and we can dig our toes together inside the code (you know, I've not started the project so I can't say I know its code by heart).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants