-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow doctrine/collections:^2.0 as alternative dependency #187
Conversation
Yes Please! |
It seems that build is failing https://github.com/liuggio/fastest/actions/runs/4171694587/jobs/7221915682 |
We have the same failure in our CI pipeline:
The v1 of Collections used to return true after every add execution: But now it doesn't return anything: I can prepare a PR to this repository, changing the return value of add to true: to keep BC. Is that ok or do you have another suggestion? |
If I'm not mistaken we never return that boolean value. Possible solutions:
WDYT? |
I don't think this small change justifies releasing a new major. I would go for option 2 ( I can prepare a PR with the changes if you agree |
Yes please, go on with option 2 |
I've created a PR: #188 |
Resolved with #188 |
Given this, seems no harm to include major version 2 as an alternative dependency.
I only noticed this as one of my projects wanted to upgrade to
doctrine/collections:^2.0
but couldn't becauseliuggio/fastest
depends exclusively on major version 1.