Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unrecognized option '--UMI--barcode': annotatorArgs improperly concatenated #232

Open
ejohnson643 opened this issue Nov 2, 2023 · 1 comment

Comments

@ejohnson643
Copy link

Hi! I discovered a wonderful bug. If you make a TRUST4 call with the --UMI specified before the --barcode as in the example below, the annotatorArgs in run-trust4 becomes --UMI--barcode because line 195 of run-trust4: $annotatorArgs .= "--barcode" ; is missing a space before the --barcode. This causes the program to quit with the error /usr/local/bin/TRUST4/annotator: unrecognized option '--UMI--barcode'.

Example script that generates the error:

run-trust4 \
    -f $ref_dir/hg38_bcrtcr.fa \
    --ref $ref_dir/human_IMGT+C.fa \
    -u $gdTCR_dir/fastqs/scTCR_control*_R2_*.fastq.gz \
    --UMI $gdTCR_dir/fastqs/scTCR_control*_R1_*fastq.gz \    ## This coming before --barcode generates the error.
    --barcode $gdTCR_dir/fastqs/scTCR_control*_R1_*fastq.gz \
    --readFormat bc:0:15,um:16:25,r1:0:25 \
    --barcodeWhitelist $ref_dir/737K-august-2016.txt \
    -t 24 \
    # --stage 2 \
    -o $gdTCR_dir/output/control/
@mourisl
Copy link
Collaborator

mourisl commented Nov 2, 2023

Thank you for reporting this issue! It is a bug in the run-trust4 wrapper where I forgot to add the space before --barcode for annotator. I just pushed the fix to the repo, and it should be fine now. Since you only need to rerun from the annotation stage with the new code, you can add the option "--stage 2" to skip running the first few stages in TRUST4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants