-
-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Code-to-image #681
Code-to-image #681
Conversation
Thank you @zyf722 for the valuable comments
Added a "Generating..." indicator and the button is displayed as disabled while generating the image.
This was a CORS error because of monaco stylesheet (which is not actually used for generating the image!).
Now, the whole field has a consistent rounded border.
I'm not sure about this. The text "Direction" is intended to be like a placeholder. It is an option with no value, falling back to the default. I do not want to add an extra label here. |
hi @gigamaster I was glad that applying your design system for the new screen (code-to-image) was straight forward and did not take much effort. Please let me know if you have any comments, or if you can come up with better presets. Thank you. |
Quality Gate passedIssues Measures |
i18n ActionsSource PR has been merged into the default branch. Maintainers can comment |
.i18n-update-push |
i18n Actions:
|
Name | Description |
---|---|
New Branch for i18n | i18n/live-codes/code-to-image |
Last Commit SHA | 333a626 |
Maintainers can comment .i18n-update-pull
after translation is done to trigger the i18n pull workflow and pull the changes back to Github.
I have added some transperancy for the code block and updated the presets before merging this. I have also added automatic translations on Lokalise. I would appreciate if you can revise the translations. I have already revised the Arabic translation. |
I've just reviewed Simplified Chinese translation and fixed some issues. Great work! This will be an excellent feature that adds some nice flavor to the application :) |
Thank you very much @zyf722 |
.i18n-update-pull |
i18n Actions:
|
Name | Description |
---|---|
i18n Branch | i18n/live-codes/code-to-image |
Last Commit SHA | bc34dc1 |
i18n PR | #692 |
What type of PR is this? (check all applicable)
Description
This PR adds a feature of taking screenshots for code and saving it as images
e.g. https://code-to-image.livecodes.pages.dev/?x=id/4dgnt5cs3nb&screen=code-to-image
Mobile & Desktop Screenshots/Recordings
Added tests?
Added to documentations?