Update outputs format #320
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonatanklosko
commented
Aug 23, 2023
Comment on lines
1
to
+2
| defmodule Kino.Output do | ||
| @moduledoc """ | ||
| A number of output formats supported by Livebook. | ||
| """ | ||
| @moduledoc false |
There was a problem hiding this comment.
I didn't bother deprecating, because I'm pretty sure in practice people don't use Kino.Output directly. Custom Kino.Render implementations generally build built-in kinos and then call Kino.Render.to_livebook/1. I also added docs to Kino.Render with examples suggesting that.
josevalim
approved these changes
Aug 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See livebook-dev/livebook#2179.