Explicitly allow imported file entries pointing to file system

[jonatanklosko]

If there are any files that point directly to a file system, we always stamp the notebook. When importing, if the stamp is invalid we put those files in quarantine and require the user to explicitly allow them.

This prevents the scenario where the user imports a valid-looking notebook that does something with a local/s3 file, except the file points somewhere they not expect.

file_entries_import.mov

[github-actions]

Uffizzi Preview deployment-31106 was deleted.

[josevalim]

LGTM!!! Quick question, when we store the file entry in the stamp, which information do we store? I assume the name, the file path, and the file system? Which parameters of the file system do we store? I assume we only store its hash? We don't store any information about where the bucket actually is, correct?

[jonatanklosko]

@josevalim the file entries information is stored as part of plain notebook metadata (readable at the top), it includes the name, file system id (for S3 we use hash of the bucket url) and the path.

With this PR what we store in the stamp is the names of file entries yet to be allowed. So if you import a file and there are disallowed entries, and you save it with the stamp, we know which entries are not yet allowed. If all files are allowed we store an empty list (because we still need the stamp).